From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH 07/11] x86: don't record full i386_cpu_flags in struct i386_tc_frag_data
Date: Wed, 27 Sep 2023 17:51:07 +0200 [thread overview]
Message-ID: <a2094e46-7176-c139-7d1f-8659032b0829@suse.com> (raw)
In-Reply-To: <7ce54bc2-fef2-d2e4-21fd-202fdead0c20@suse.com>
We only use a single bit of this ever growing structure.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -1470,7 +1470,7 @@ i386_generate_nops (fragS *fragP, char *
case PROCESSOR_UNKNOWN:
/* We use cpu_arch_isa_flags to check if we SHOULD
optimize with nops. */
- if (fragP->tc_frag_data.isa_flags.bitfield.cpunop)
+ if (fragP->tc_frag_data.isanop)
patt = alt_patt;
break;
@@ -1516,7 +1516,7 @@ i386_generate_nops (fragS *fragP, char *
default:
/* We use cpu_arch_isa_flags to check if we CAN optimize
with nops. */
- if (fragP->tc_frag_data.isa_flags.bitfield.cpunop)
+ if (fragP->tc_frag_data.isanop)
patt = alt_patt;
break;
--- a/gas/config/tc-i386.h
+++ b/gas/config/tc-i386.h
@@ -284,7 +284,6 @@ struct i386_tc_frag_data
} u;
addressT padding_address;
enum processor_type isa;
- i386_cpu_flags isa_flags;
enum processor_type tune;
enum i386_flag_code code;
unsigned int max_bytes;
@@ -298,6 +297,7 @@ struct i386_tc_frag_data
unsigned int classified : 1;
unsigned int branch_type : 3;
unsigned int cpunop : 1;
+ unsigned int isanop : 1;
};
/* We need to emit the right NOP pattern in .align frags. This is
@@ -311,9 +311,9 @@ struct i386_tc_frag_data
(FRAGP)->tc_frag_data.u.padding_fragP = NULL; \
(FRAGP)->tc_frag_data.padding_address = 0; \
(FRAGP)->tc_frag_data.isa = cpu_arch_isa; \
- (FRAGP)->tc_frag_data.isa_flags = cpu_arch_isa_flags; \
(FRAGP)->tc_frag_data.tune = cpu_arch_tune; \
(FRAGP)->tc_frag_data.cpunop = cpu_arch_flags.bitfield.cpunop; \
+ (FRAGP)->tc_frag_data.isanop = cpu_arch_isa_flags.bitfield.cpunop; \
(FRAGP)->tc_frag_data.code = i386_flag_code; \
(FRAGP)->tc_frag_data.max_bytes = (MAX_BYTES); \
(FRAGP)->tc_frag_data.length = 0; \
next prev parent reply other threads:[~2023-09-27 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 15:46 [PATCH 00/11] x86: NOP emission adjustments Jan Beulich
2023-09-27 15:47 ` [PATCH 01/11] x86: record flag_code in tc_frag_data Jan Beulich
2023-09-27 15:48 ` [PATCH 02/11] x86: i386_generate_nops() may not derive decisions from global variables Jan Beulich
2023-09-27 15:48 ` [PATCH 03/11] x86: don't use 32-bit LEA as NOP surrogate in 64-bit code Jan Beulich
2023-09-27 15:49 ` [PATCH 04/11] x86: don't use operand size override with NOP in 16-bit code Jan Beulich
2023-09-27 15:50 ` [PATCH 05/11] x86: respect ".arch nonop" when selecting which NOPs to emit Jan Beulich
2023-09-27 15:50 ` [PATCH 06/11] x86: i686 != PentiumPro Jan Beulich
2023-09-27 15:51 ` Jan Beulich [this message]
2023-09-27 15:51 ` [PATCH 08/11] x86: add a few more NOP patterns Jan Beulich
2023-09-27 15:52 ` [PATCH 09/11] x86: fold a few of the "alternative" " Jan Beulich
2023-09-27 15:52 ` [PATCH 10/11] x86: fold NOP testcase expectations where possible Jan Beulich
2023-09-27 15:53 ` [PATCH 11/11] gas: make .nops output visible in listing Jan Beulich
2023-09-27 15:59 ` [PATCH 00/11] x86: NOP emission adjustments Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2094e46-7176-c139-7d1f-8659032b0829@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).