From: Jan Beulich <jbeulich@suse.com>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH, V5 11/16] opcodes: i386: new marker for insns that implicitly update stack pointer
Date: Thu, 11 Jan 2024 08:57:54 +0100 [thread overview]
Message-ID: <a63030d1-9aed-4c15-b2b4-9b9974381b81@suse.com> (raw)
In-Reply-To: <20240111074820.2677826-12-indu.bhagat@oracle.com>
On 11.01.2024 08:48, Indu Bhagat wrote:
> [Changes from V4 to V5]
> - IMPLICIT_STACK_OP as a new constraint (was attribute in V4).
> [End of Changes from V4 to V5]
>
> [New in V4]
>
> Some x86 instructions affect the stack pointer implicitly. Add a new
> operand constraint to reflect this. This will be useful for SCFI
> implmentation to ensure its correctness.
>
> Mark all push, pop, call, ret, enter, leave, INT, iret instructions.
>
> opcodes/
> * i386-gen.c: Update opcode_modifiers.
> * i386-opc.h: Add a new constraint.
> * i386-opc.tbl: Update the affected instructions.
> * i386-tbl.h: Regenerated.
This and patch 10 are okay as long as not committed ahead of time.
Jan
next prev parent reply other threads:[~2024-01-11 7:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 7:48 [PATCH, V5 00/16] Experimental support for synthesizing CFI for hand-written asm Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 01/16] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 02/16] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 03/16] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 04/16] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 05/16] gas: dw2gencfi: expose dot_cfi_sections for scfidw2gen Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 06/16] gas: dw2gencfi: externalize the all_cfi_sections Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 07/16] gas: add new command line option --scfi=experimental Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 08/16] gas: scfidw2gen: new functionality to prepare for SCFI Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 09/16] opcodes: i386: fix dw2_regnum data type in reg_entry Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 10/16] opcodes: gas: i386: define and use Rex2 as attribute not constraint Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 11/16] opcodes: i386: new marker for insns that implicitly update stack pointer Indu Bhagat
2024-01-11 7:57 ` Jan Beulich [this message]
2024-01-11 7:48 ` [PATCH, V5 12/16] gas: synthesize CFI for hand-written asm Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 13/16] gas: doc: update documentation for the new listing option Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 14/16] opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering Indu Bhagat
2024-01-11 7:59 ` Jan Beulich
2024-01-11 7:48 ` [PATCH, V5 15/16] gas: testsuite: add an x86_64 testsuite for SCFI Indu Bhagat
2024-01-11 7:48 ` [PATCH, V5 16/16] gas/NEWS: announce the new SCFI command line option Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63030d1-9aed-4c15-b2b4-9b9974381b81@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).