* [PATCH] SCFI: correct test names
@ 2024-02-09 6:58 Jan Beulich
2024-02-09 7:29 ` Indu Bhagat
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2024-02-09 6:58 UTC (permalink / raw)
To: Binutils; +Cc: Indu Bhagat
Having multiple tests with the same name is confusing.
---
I only noticed these because I had to make further adjustments to the
overly strict expectations, to accommodate a local change of mine
(adding
#define EH_FRAME_ALIGNMENT 2
to tc-i386.h). I've yet to decide whether I actually want to upstream
that change.
--- a/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
+++ b/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
@@ -1,7 +1,7 @@
#as: --scfi=experimental -W
#as:
#objdump: -Wf
-#name: Synthesize CFI for indirect mem op to stack 3
+#name: Synthesize CFI for indirect mem op to stack 4
#...
Contents of the .eh_frame section:
--- a/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
+++ b/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
@@ -1,7 +1,7 @@
#as: --scfi=experimental -W
#as:
#objdump: -Wf
-#name: Synthesize CFI for demarcated code blocks 2
+#name: Synthesize CFI with pushsection 2
#...
Contents of the .eh_frame section:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] SCFI: correct test names
2024-02-09 6:58 [PATCH] SCFI: correct test names Jan Beulich
@ 2024-02-09 7:29 ` Indu Bhagat
0 siblings, 0 replies; 2+ messages in thread
From: Indu Bhagat @ 2024-02-09 7:29 UTC (permalink / raw)
To: Jan Beulich, Binutils
On 2/8/24 22:58, Jan Beulich wrote:
> Having multiple tests with the same name is confusing.
> ---
> I only noticed these because I had to make further adjustments to the
> overly strict expectations, to accommodate a local change of mine
> (adding
>
> #define EH_FRAME_ALIGNMENT 2
>
> to tc-i386.h). I've yet to decide whether I actually want to upstream
> that change.
>
> --- a/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
> @@ -1,7 +1,7 @@
> #as: --scfi=experimental -W
> #as:
> #objdump: -Wf
> -#name: Synthesize CFI for indirect mem op to stack 3
> +#name: Synthesize CFI for indirect mem op to stack 4
> #...
> Contents of the .eh_frame section:
>
> --- a/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
> @@ -1,7 +1,7 @@
> #as: --scfi=experimental -W
> #as:
> #objdump: -Wf
> -#name: Synthesize CFI for demarcated code blocks 2
> +#name: Synthesize CFI with pushsection 2
> #...
> Contents of the .eh_frame section:
>
Thanks for fixing these.
Indu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-09 6:58 [PATCH] SCFI: correct test names Jan Beulich
2024-02-09 7:29 ` Indu Bhagat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).