From: Indu Bhagat <indu.bhagat@oracle.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH,RFC 0/9] SCFI implementation in GNU assembler
Date: Fri, 29 Sep 2023 23:44:23 -0700 [thread overview]
Message-ID: <ae4b7980-7778-ad4d-08ce-37daa24f247c@oracle.com> (raw)
In-Reply-To: <c4eaa130-0031-bb5d-cb7e-247736c8f421@redhat.com>
On 9/28/23 08:01, Nick Clifton wrote:
> Hi Indu,
>
>> This is an RFC patch series for the implementation in GNU assembler to
>> > synthesize CFI, a.k.a. SCFI, for hand-written asm.
> Overall I would say that this patch series is excellent. I have posted
> a few minor comments about specific items in the series, but as a whole
> I would be happy to accept the patch series as-is.
>
> I would recommend holding off on adding the support for inline assembler
> for now. Get the basic framework into the source tree, wait for any
> fallout,
> and then when everything is settled, start extending the code.
>
Thanks a lot for reviewing.
I will address the review comments and test out the implementation a bit
more. I will send an updated version soon.
Thanks
Indu
prev parent reply other threads:[~2023-09-30 6:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 23:03 Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 1/9] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 2/9] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 3/9] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 4/9] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 5/9] gas: add new command line option --scfi[=all,none] Indu Bhagat
2023-09-28 14:04 ` Nick Clifton
2023-09-30 6:13 ` Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 6/9] gas: dw2gencfi: ignore all .cfi_* directives with --scfi=all Indu Bhagat
2023-09-28 14:10 ` [PATCH, RFC " Nick Clifton
2023-09-30 6:20 ` Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 7/9] gas: scfidw2gen: new functionality to prepapre for SCFI Indu Bhagat
2023-09-20 23:04 ` [PATCH,RFC 8/9] gas: synthesize CFI for hand-written asm Indu Bhagat
2023-09-28 14:58 ` Nick Clifton
2023-09-30 6:43 ` Indu Bhagat
2023-09-20 23:04 ` [PATCH,RFC 9/9] gas: testsuite: add a x86_64 testsuite for SCFI Indu Bhagat
2023-09-28 15:01 ` [PATCH,RFC 0/9] SCFI implementation in GNU assembler Nick Clifton
2023-09-30 6:44 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4b7980-7778-ad4d-08ce-37daa24f247c@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).