From: Nick Clifton <nickc@redhat.com>
To: Indu Bhagat <indu.bhagat@oracle.com>, binutils@sourceware.org
Subject: Re: [PATCH,RFC 5/9] gas: add new command line option --scfi[=all,none]
Date: Thu, 28 Sep 2023 15:04:44 +0100 [thread overview]
Message-ID: <6582d489-7ac5-6c4d-cfc2-8e5ca7e399e4@redhat.com> (raw)
In-Reply-To: <20230920230401.1739139-6-indu.bhagat@oracle.com>
Hi Indu,
> When the command line option --scfi (default is --scfi=all) is passed to
> the GNU assembler, it will synthesize DWARF call frame information (CFI)
> for the assembly.
> Also document the option.
Please could you also add an entry in the gas/NEWS file about this new feature.
> +# ifdef TARGET_USE_SCFI
> + fprintf (stream, _("\
> + --scfi=[all,none] synthesize DWARF CFI for hand-written asm (not inline)\n\
> + (default --scfi=all)\n"));
> +# endif
I was wondering how the code would detect inline assembler.
Presumably it looks for the #NOAPP preprocessor directive ?
Or is the point of the comment in the above delta that the
user should not use this new option in conjunction with actual
compiled code ? Either way I think that you need to extend
the documentation to include describing what happens when
compiled code and this option are used together.
Also - I have not checked this yet - if this option is enabled
and no CFI statements are generated (or maybe if an incomplete
sequence is generated) - presumably because of badly written
code - will there be an error message generated ?
Cheers
Nick
next prev parent reply other threads:[~2023-09-28 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 23:03 [PATCH,RFC 0/9] SCFI implementation in GNU assembler Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 1/9] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 2/9] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 3/9] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 4/9] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 5/9] gas: add new command line option --scfi[=all,none] Indu Bhagat
2023-09-28 14:04 ` Nick Clifton [this message]
2023-09-30 6:13 ` Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 6/9] gas: dw2gencfi: ignore all .cfi_* directives with --scfi=all Indu Bhagat
2023-09-28 14:10 ` [PATCH, RFC " Nick Clifton
2023-09-30 6:20 ` Indu Bhagat
2023-09-20 23:03 ` [PATCH,RFC 7/9] gas: scfidw2gen: new functionality to prepapre for SCFI Indu Bhagat
2023-09-20 23:04 ` [PATCH,RFC 8/9] gas: synthesize CFI for hand-written asm Indu Bhagat
2023-09-28 14:58 ` Nick Clifton
2023-09-30 6:43 ` Indu Bhagat
2023-09-20 23:04 ` [PATCH,RFC 9/9] gas: testsuite: add a x86_64 testsuite for SCFI Indu Bhagat
2023-09-28 15:01 ` [PATCH,RFC 0/9] SCFI implementation in GNU assembler Nick Clifton
2023-09-30 6:44 ` Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6582d489-7ac5-6c4d-cfc2-8e5ca7e399e4@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).