public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 2/2] arm: Add missing Neoverse V1 feature
@ 2020-09-25 11:14 Alex Coplan
  2020-09-28 11:01 ` Nick Clifton
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Coplan @ 2020-09-25 11:14 UTC (permalink / raw)
  To: binutils; +Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

This simple follow-on patch adds a feature bit (FP16) that was missing
from the initial Neoverse V1 support.

Testing:
 * Regression tested on arm-none-eabi.

OK for master?

Thanks,
Alex

---

gas/ChangeLog:

2020-09-25  Alex Coplan  <alex.coplan@arm.com>

	* config/tc-arm.c (arm_cpus): Add FP16 to Neoverse V1.

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 674 bytes --]

diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 455a1401b7f..39f989ea99c 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -31600,7 +31600,9 @@ static const struct arm_cpu_option_table arm_cpus[] =
 				    | ARM_EXT2_I8MM),
 	       FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_4),
   ARM_CPU_OPT ("neoverse-v1", "Neoverse V1", ARM_ARCH_V8_4A,
-	       ARM_FEATURE_CORE_HIGH (ARM_EXT2_BF16 | ARM_EXT2_I8MM),
+	       ARM_FEATURE_CORE_HIGH (ARM_EXT2_FP16_INST
+				    | ARM_EXT2_BF16
+				    | ARM_EXT2_I8MM),
 	       FPU_ARCH_CRYPTO_NEON_VFP_ARMV8_4),
   /* ??? XSCALE is really an architecture.  */
   ARM_CPU_OPT ("xscale",	  NULL,		       ARM_ARCH_XSCALE,

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm: Add missing Neoverse V1 feature
  2020-09-25 11:14 [PATCH 2/2] arm: Add missing Neoverse V1 feature Alex Coplan
@ 2020-09-28 11:01 ` Nick Clifton
  2020-09-28 11:30   ` Alex Coplan
  0 siblings, 1 reply; 4+ messages in thread
From: Nick Clifton @ 2020-09-28 11:01 UTC (permalink / raw)
  To: Alex Coplan, binutils; +Cc: Richard Earnshaw, Ramana Radhakrishnan

Hi Alex,

> gas/ChangeLog:
> 2020-09-25  Alex Coplan  <alex.coplan@arm.com>
> 
> 	* config/tc-arm.c (arm_cpus): Add FP16 to Neoverse V1.

Approved - please apply.

Cheers
  Nick



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm: Add missing Neoverse V1 feature
  2020-09-28 11:01 ` Nick Clifton
@ 2020-09-28 11:30   ` Alex Coplan
  2020-09-28 11:49     ` Nick Clifton
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Coplan @ 2020-09-28 11:30 UTC (permalink / raw)
  To: Nick Clifton; +Cc: binutils, Richard Earnshaw, Ramana Radhakrishnan

Hi Nick,

On 28/09/2020 12:01, Nick Clifton wrote:
> Hi Alex,
> 
> > gas/ChangeLog:
> > 2020-09-25  Alex Coplan  <alex.coplan@arm.com>
> > 
> > 	* config/tc-arm.c (arm_cpus): Add FP16 to Neoverse V1.
> 
> Approved - please apply.

Thanks. Is the AArch64 patch (1/2) OK as well?

Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm: Add missing Neoverse V1 feature
  2020-09-28 11:30   ` Alex Coplan
@ 2020-09-28 11:49     ` Nick Clifton
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2020-09-28 11:49 UTC (permalink / raw)
  To: Alex Coplan; +Cc: binutils, Richard Earnshaw, Ramana Radhakrishnan

Hi Alex,

> Thanks. Is the AArch64 patch (1/2) OK as well?

Doh - sorry - yes that patch is approved too.

Cheers
  Nick



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-28 11:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 11:14 [PATCH 2/2] arm: Add missing Neoverse V1 feature Alex Coplan
2020-09-28 11:01 ` Nick Clifton
2020-09-28 11:30   ` Alex Coplan
2020-09-28 11:49     ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).