From: Hans-Peter Nilsson <hp@bitrange.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v2] gas: equates of registers
Date: Tue, 2 May 2023 19:37:07 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2305021931310.52809@arjuna.pair.com> (raw)
In-Reply-To: <3a7b6bb3-4ab0-15af-0c74-5d7798ac3793@suse.com>
On Tue, 2 May 2023, Jan Beulich wrote:
> There are two problems: symbol_equated_p() doesn't recognize equates of
> registers, and S_CAN_BE_REDEFINED() goes by section rather than by
> expression type. Both together undermine .eqv and .equiv clearly meaning
> to guard the involved symbols against re-definition (both ways).
>
> To compensate pseudo_set() now using O_symbol and S_CAN_BE_REDEFINED()
> now checking for O_register,
> - for targets creating register symbols through symbol_{new,create}() ->
> symbol_init() -> S_SET_VALUE() (alpha, arc, dlx, ia64, m68k, mips,
> mmix, tic4x, tic54x, plus anything using cgen or itbl-ops), have
> symbol_init() set their expressions to O_register,
(Heads-up for maintainers or asking for approval though being a
global maintainer? Anyway...)
Ok for mmix iff the binutils test-suites (ld, gas, binutils)
shows no regressions for mmix with this patch.
brgds, H-P
next prev parent reply other threads:[~2023-05-02 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 9:04 Jan Beulich
2023-05-02 23:37 ` Hans-Peter Nilsson [this message]
2023-05-03 6:56 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2305021931310.52809@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).