public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Sagar Patel <sagarmp@cs.unc.edu>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] MIPS/opcodes: Fix alias annotation for negate instructions
Date: Thu, 10 Mar 2022 10:11:59 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2203101008370.47558@angie.orcam.me.uk> (raw)
In-Reply-To: <CAMGmevBtbn+HUN-8j0qK-1U2M3gmizKX8DR+v4WhoETy=GzPrw@mail.gmail.com>

On Tue, 8 Mar 2022, Sagar Patel wrote:

> >  This might be overly pedantic, but with any test case I suggest putting
> > the absolute minimum there so as not to make someone in the future wonder
> > what the specific requirement was for one option or another (possibly I
> > shouldn't have used `.set noat' and $1 either, but let's leave it as it
> > is).
> 
> I agree. I can remove the use of `.set noat' in the two new test
> sources. Should I do that?

 Please do whatever you prefer and I will accept your choice.  This is a 
minor difference and I surely cannot impose requirements on you that I do 
not stick to myself.

> >  It looks perfect otherwise and once your paperwork has been sorted I will
> > push either your change as posted with amendments made for the two pieces
> > above or any v2 if you prefer to make one yourself.
> 
> Just to keep you in the loop, I sent in the request for the paperwork.
> I'll let you know if I don't hear back soon.

 Ack, thanks.

  Maciej

      reply	other threads:[~2022-03-10 10:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 15:18 Sagar Patel
2022-03-07 20:46 ` Maciej W. Rozycki
2022-03-08  6:25   ` Sagar Patel
2022-03-10 10:11     ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2203101008370.47558@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=binutils@sourceware.org \
    --cc=sagarmp@cs.unc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).