From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Andrew Burgess <aburgess@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] opcodes/mips: use .word/.short for undefined instructions
Date: Wed, 1 Feb 2023 10:40:25 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2301312350580.4010@angie.orcam.me.uk> (raw)
In-Reply-To: <87o7qguzzx.fsf@redhat.com>
Andrew,
> I've updated the patch. Let me know what you think.
I'd say it's OK, except that I put your change through my MIPS regression
tester and that revealed failures from your new case for numerous targets,
e.g.:
mips-elf +FAIL: microMIPS source file contains reserved encoding (o32)
mips-img-elf +FAIL: microMIPS source file contains reserved encoding (o32)
mips-img-elf +FAIL: microMIPS source file contains reserved encoding (n32)
etc. The usual suspect is section padding owing to different alignments
used with individual MIPS targets, e.g.:
extra regexps in
.../binutils/testsuite/binutils-all/mips/micromips-reserved-enc-o32.d starting with "^
\.\.\.$"
EOF from tmpdir/dump.out
FAIL: microMIPS source file contains reserved encoding (o32)
See e.g. binutils/testsuite/binutils-all/mips/micromips-branch-alias.s for
how to add suitable padding at the end.
And then:
mipsisa32r6-elf +FAIL: microMIPS source file contains reserved encoding (o32)
mipsisa32r6-linux +FAIL: microMIPS source file contains reserved encoding (o32)
mipsisa32r6el-elf +FAIL: microMIPS source file contains reserved encoding (o32)
etc., due to:
.../binutils/testsuite/binutils-all/mips/micromips-reserved-enc.s: Assembler messages:
.../binutils/testsuite/binutils-all/mips/micromips-reserved-enc.s:3: Fatal error: `micromips' cannot be used with `mips32r6'
We don't care about different ISA levels here, so let's set a reasonable
one, as in binutils/testsuite/binutils-all/mips/micromips-branch-alias.s
again:
.module mips64r3
(it could be `.set' too, but let's be consistent, and it has to be a
64-bit one for the n32/n64 ABIs).
OK with these updates, thank you for your contribution.
Maciej
next prev parent reply other threads:[~2023-02-01 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 13:58 [PATCH 0/2] MIPS disassembler styling Andrew Burgess
2022-11-03 13:58 ` [PATCH 1/2] opcodes/mips: use .word/.short for undefined instructions Andrew Burgess
2023-01-06 15:58 ` Maciej W. Rozycki
2023-01-06 16:40 ` Andrew Burgess
2023-01-08 16:05 ` Maciej W. Rozycki
2023-01-17 10:28 ` Andrew Burgess
2023-01-27 11:57 ` Maciej W. Rozycki
2023-01-30 9:34 ` Andrew Burgess
2023-02-01 10:40 ` Maciej W. Rozycki [this message]
2023-02-01 15:32 ` Andrew Burgess
2023-02-02 9:48 ` Maciej W. Rozycki
2023-02-03 9:31 ` Andrew Burgess
2023-02-13 12:07 ` Andrew Burgess
2023-02-14 4:43 ` Maciej W. Rozycki
2022-11-03 13:58 ` [PATCH 2/2] libopcodes/mips: add support for disassembler styling Andrew Burgess
2022-11-28 17:15 ` [PATCH 0/2] MIPS " Andrew Burgess
2022-11-30 16:50 ` Nick Clifton
2022-12-05 10:08 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2301312350580.4010@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).