Don't run new orphan tests on i860 and i960

Don't run new orphan tests on i860 and i960

[Alan Modra]

These targets use the generic ELF support, so don't handle orphans
well.  The patch also updates the orphan doco to reflect this fact,
and deletes some ELF details that don't really add anything.

	* ld.texinfo (Orphan Sections): Mention that not all targets
	handle orphans well.  Delete ELF details.
	* testsuite/ld-elf/orphan-9.d: Don't run for i860 and i960.
	* testsuite/ld-elf/orphan-10.d: Likewise.

diff --git a/ld/ChangeLog b/ld/ChangeLog
index adefe32..2ea7630 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2017-03-11  Alan Modra  <amodra@gmail.com>
+
+	* ld.texinfo (Orphan Sections): Mention that not all targets
+	handle orphans well.
+	* testsuite/ld-elf/orphan-9.d: Don't run for i860 and i960.
+	* testsuite/ld-elf/orphan-10.d: Likewise.
+
 2017-03-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* ldlang.c (lang_size_sections_1): Shortcut loop only after
diff --git a/ld/ld.texinfo b/ld/ld.texinfo
index 176b9f2..769725d 100644
--- a/ld/ld.texinfo
+++ b/ld/ld.texinfo
@@ -5777,14 +5777,11 @@ one new output section.
 
 If new output sections are created to hold orphaned input sections,
 then the linker must decide where to place these new output sections
-in relation to existing output sections.  The linker uses a simple
-heuristic to do this.  It attempts to place orphan sections after
-sections of the same attribute, such as code vs data, loadable vs
-non-loadable, etc.  If no sections with matching attributes are found,
-the orphan section is placed at the end of the file.
-
-For ELF targets, the attribute of the section includes section type as
-well as section flag.
+in relation to existing output sections.  On most modern targets, the
+linker attempts to place orphan sections after sections of the same
+attribute, such as code vs data, loadable vs non-loadable, etc.  If no
+sections with matching attributes are found, or your target lacks this
+support, the orphan section is placed at the end of the file.
 
 The command line options @samp{--orphan-handling} and @samp{--unique}
 (@pxref{Options,,Command Line Options}) can be used to control which
diff --git a/ld/testsuite/ld-elf/orphan-10.d b/ld/testsuite/ld-elf/orphan-10.d
index a5cf6d9..1dbec42 100644
--- a/ld/testsuite/ld-elf/orphan-10.d
+++ b/ld/testsuite/ld-elf/orphan-10.d
@@ -1,7 +1,7 @@
 #source: orphan-10.s
 #ld: -N -T orphan-9.ld
 #objdump: -h
-#notarget: d30v-* dlx-* fr30-* frv-* ft32-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
+#notarget: d30v-* dlx-* fr30-* frv-* ft32-* i860-* i960-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
 
 #...
   . \.text         0+(08|10)  [0-9a-f]+  0+200 .*
diff --git a/ld/testsuite/ld-elf/orphan-9.d b/ld/testsuite/ld-elf/orphan-9.d
index 637e8c5..790cff1 100644
--- a/ld/testsuite/ld-elf/orphan-9.d
+++ b/ld/testsuite/ld-elf/orphan-9.d
@@ -1,7 +1,7 @@
 #source: orphan-9.s
 #ld: -N -T orphan-9.ld
 #objdump: -h
-#notarget: d30v-* dlx-* fr30-* frv-* ft32-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
+#notarget: d30v-* dlx-* fr30-* frv-* ft32-* i860-* i960-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
 
 #...
   . \.text         0+(08|10)  [0-9a-f]+  0+200 .*

-- 
Alan Modra
Australia Development Lab, IBM

Re: Don't run new orphan tests on i860 and i960

[Andrew Burgess]

* Alan Modra <amodra@gmail.com> [2017-03-11 11:34:57 +1030]:

> These targets use the generic ELF support, so don't handle orphans
> well.  The patch also updates the orphan doco to reflect this fact,
> and deletes some ELF details that don't really add anything.

Alan,

Sorry for introducing these failures.

What target triplets do you use for building/testing i860 and i960?
I'd love to add these to my list of build targets that I test.

And more generally do you have a complete list of targets that you
regularly test?  If you do and could/would share I could check that
there's no other targets that I've missed.

Thanks,
Andrew




> 
> 	* ld.texinfo (Orphan Sections): Mention that not all targets
> 	handle orphans well.  Delete ELF details.
> 	* testsuite/ld-elf/orphan-9.d: Don't run for i860 and i960.
> 	* testsuite/ld-elf/orphan-10.d: Likewise.
> 
> diff --git a/ld/ChangeLog b/ld/ChangeLog
> index adefe32..2ea7630 100644
> --- a/ld/ChangeLog
> +++ b/ld/ChangeLog
> @@ -1,3 +1,10 @@
> +2017-03-11  Alan Modra  <amodra@gmail.com>
> +
> +	* ld.texinfo (Orphan Sections): Mention that not all targets
> +	handle orphans well.
> +	* testsuite/ld-elf/orphan-9.d: Don't run for i860 and i960.
> +	* testsuite/ld-elf/orphan-10.d: Likewise.
> +
>  2017-03-09  Andrew Burgess  <andrew.burgess@embecosm.com>
>  
>  	* ldlang.c (lang_size_sections_1): Shortcut loop only after
> diff --git a/ld/ld.texinfo b/ld/ld.texinfo
> index 176b9f2..769725d 100644
> --- a/ld/ld.texinfo
> +++ b/ld/ld.texinfo
> @@ -5777,14 +5777,11 @@ one new output section.
>  
>  If new output sections are created to hold orphaned input sections,
>  then the linker must decide where to place these new output sections
> -in relation to existing output sections.  The linker uses a simple
> -heuristic to do this.  It attempts to place orphan sections after
> -sections of the same attribute, such as code vs data, loadable vs
> -non-loadable, etc.  If no sections with matching attributes are found,
> -the orphan section is placed at the end of the file.
> -
> -For ELF targets, the attribute of the section includes section type as
> -well as section flag.
> +in relation to existing output sections.  On most modern targets, the
> +linker attempts to place orphan sections after sections of the same
> +attribute, such as code vs data, loadable vs non-loadable, etc.  If no
> +sections with matching attributes are found, or your target lacks this
> +support, the orphan section is placed at the end of the file.
>  
>  The command line options @samp{--orphan-handling} and @samp{--unique}
>  (@pxref{Options,,Command Line Options}) can be used to control which
> diff --git a/ld/testsuite/ld-elf/orphan-10.d b/ld/testsuite/ld-elf/orphan-10.d
> index a5cf6d9..1dbec42 100644
> --- a/ld/testsuite/ld-elf/orphan-10.d
> +++ b/ld/testsuite/ld-elf/orphan-10.d
> @@ -1,7 +1,7 @@
>  #source: orphan-10.s
>  #ld: -N -T orphan-9.ld
>  #objdump: -h
> -#notarget: d30v-* dlx-* fr30-* frv-* ft32-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
> +#notarget: d30v-* dlx-* fr30-* frv-* ft32-* i860-* i960-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
>  
>  #...
>    . \.text         0+(08|10)  [0-9a-f]+  0+200 .*
> diff --git a/ld/testsuite/ld-elf/orphan-9.d b/ld/testsuite/ld-elf/orphan-9.d
> index 637e8c5..790cff1 100644
> --- a/ld/testsuite/ld-elf/orphan-9.d
> +++ b/ld/testsuite/ld-elf/orphan-9.d
> @@ -1,7 +1,7 @@
>  #source: orphan-9.s
>  #ld: -N -T orphan-9.ld
>  #objdump: -h
> -#notarget: d30v-* dlx-* fr30-* frv-* ft32-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
> +#notarget: d30v-* dlx-* fr30-* frv-* ft32-* i860-* i960-* iq2000-* mn10200-* moxie-* ms1-* msp430-* mt-* pj-*
>  
>  #...
>    . \.text         0+(08|10)  [0-9a-f]+  0+200 .*
> 
> -- 
> Alan Modra
> Australia Development Lab, IBM

Re: Don't run new orphan tests on i860 and i960

[Tristan Gingold]

> On 16 Mar 2017, at 11:26, Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> 
> * Alan Modra <amodra@gmail.com> [2017-03-11 11:34:57 +1030]:
> 
>> These targets use the generic ELF support, so don't handle orphans
>> well.  The patch also updates the orphan doco to reflect this fact,
>> and deletes some ELF details that don't really add anything.
> 
> Alan,
> 
> Sorry for introducing these failures.
> 
> What target triplets do you use for building/testing i860 and i960?
> I'd love to add these to my list of build targets that I test.

Note that they are both obsolete targets.

Tristan.

Re: Don't run new orphan tests on i860 and i960

[Michael Matz]

Hi,

On Thu, 16 Mar 2017, Andrew Burgess wrote:

> Sorry for introducing these failures.
> 
> What target triplets do you use for building/testing i860 and i960? I'd 
> love to add these to my list of build targets that I test.

Alan uses this: http://sourceware.org/ml/binutils/2017-03/msg00051.html
:)


Ciao,
Michael.

Re: Don't run new orphan tests on i860 and i960

[Alan Modra]

On Thu, Mar 16, 2017 at 11:31:52AM +0100, Tristan Gingold wrote:
> 
> > On 16 Mar 2017, at 11:26, Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> > 
> > * Alan Modra <amodra@gmail.com> [2017-03-11 11:34:57 +1030]:
> > 
> >> These targets use the generic ELF support, so don't handle orphans
> >> well.  The patch also updates the orphan doco to reflect this fact,
> >> and deletes some ELF details that don't really add anything.
> > 
> > Alan,
> > 
> > Sorry for introducing these failures.
> > 
> > What target triplets do you use for building/testing i860 and i960?
> > I'd love to add these to my list of build targets that I test.
> 
> Note that they are both obsolete targets.

Yeah, I probably should remove them from the list of targets I test.
It does seem a waste of time to even be looking at them.

-- 
Alan Modra
Australia Development Lab, IBM