From: "Martin Storsjö" <martin@martin.st>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: "nickc@redhat.com" <nickc@redhat.com>,
Mark Harmstone <mark@harmstone.com>,
Andrew Pinski <pinskia@gmail.com>,
Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
NightStrike <nightstrike@gmail.com>,
"wej22007@outlook.com" <wej22007@outlook.com>,
"zac.walker@linaro.org" <zac.walker@linaro.org>,
binutils <binutils@sourceware.org>
Subject: RE: [PATCH 1/8] ld: Rename aarch64pe emulation target to arm64pe
Date: Wed, 4 Jan 2023 13:36:29 +0200 (EET) [thread overview]
Message-ID: <b140734-145f-db27-1a7a-c5f4c852aae7@martin.st> (raw)
In-Reply-To: <VI1PR08MB53257D937E9F00D0278254BDFFF59@VI1PR08MB5325.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]
On Wed, 4 Jan 2023, Tamar Christina wrote:
>> -----Original Message-----
>> From: Martin Storsjö <martin@martin.st>
>> Sent: Wednesday, January 4, 2023 11:00 AM
>> To: Tamar Christina <Tamar.Christina@arm.com>
>> Cc: nickc@redhat.com; Mark Harmstone <mark@harmstone.com>; Andrew
>> Pinski <pinskia@gmail.com>; Richard Earnshaw
>> <Richard.Earnshaw@foss.arm.com>; NightStrike <nightstrike@gmail.com>;
>> wej22007@outlook.com; zac.walker@linaro.org; binutils
>> <binutils@sourceware.org>
>> Subject: RE: [PATCH 1/8] ld: Rename aarch64pe emulation target to arm64pe
>>
>> On Wed, 4 Jan 2023, Tamar Christina wrote:
>>
>>> To be clear, GCC will very likely reject any port upstreaming that
>>> uses
>>> Arm64 for the same reason. And GCC is a lot more tightly controlled.
>>> At least if you want upstream support.
>>>
>>> Believe it or not I'm actually trying to help you here, the fact that
>>> clang has called it arm64 is why we want to allow the alias. As I
>>> mentioned before, it just can't be the main name.
>>
>> Right - but in the case of GCC, it wouldn't be the name of a new port - it
>> would only be a single word in a file for passing linker arguments. Just like
>> how "-m i386pep" is passed for x86_64 today here:
>> https://github.com/gcc-
>> mirror/gcc/blob/345dffd0d4ebff7e705dfff1a8a72017a167120a/gcc/config/i38
>> 6/mingw-w64.h#L74
>>
>> So regardless of the binutils discussion, are you saying that GCC would reject
>> a patch that adds such an occurance that would pass "-m arm64pe", in a
>> patch that otherwise consistently calls the port "aarch64"?
>
> If it's driver only and has no source implications then It might be ok.
> But look at this patch, it's not driver only. By renaming the emulation
> target it also renamed the internal macros. It makes us have to
> maintain the name "arm64" in the source code along with what everything
> else calls aarch64 and this has more implications.
Ok, thanks for clarifying the concern - I see your point now.
// Martin
next prev parent reply other threads:[~2023-01-04 11:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 2:40 Mark Harmstone
2022-12-30 2:40 ` [PATCH 2/8] Fix size of external_reloc for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 3/8] Skip ELF-specific tests when targeting pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 4/8] Skip big-obj test for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 5/8] Add pe-aarch64 relocations Mark Harmstone
2022-12-30 2:40 ` [PATCH 6/8] Add .secrel32 for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 7/8] Add aarch64-w64-mingw32 target Mark Harmstone
2022-12-30 2:40 ` [PATCH 8/8] gas: Restore tc_pe_dwarf2_emit_offset for pe-aarch64 Mark Harmstone
2023-01-03 11:54 ` [PATCH 1/8] ld: Rename aarch64pe emulation target to arm64pe Nick Clifton
2023-01-03 11:59 ` NightStrike
2023-01-03 12:09 ` Tamar Christina
2023-01-03 14:08 ` Richard Earnshaw
2023-01-03 14:13 ` Martin Storsjö
2023-01-03 14:54 ` Tamar Christina
2023-01-03 15:51 ` Martin Storsjö
2023-01-03 15:57 ` Tamar Christina
2023-01-03 18:21 ` Mark Harmstone
2023-01-03 18:33 ` Andrew Pinski
2023-01-03 19:07 ` Mark Harmstone
2023-01-03 19:41 ` Tamar Christina
2023-01-03 20:05 ` Martin Storsjö
2023-01-04 2:38 ` Mark Harmstone
2023-01-04 9:51 ` Nick Clifton
2023-01-04 10:25 ` Martin Storsjö
2023-01-04 10:35 ` Tamar Christina
2023-01-04 11:00 ` Martin Storsjö
2023-01-04 11:08 ` Tamar Christina
2023-01-04 11:36 ` Martin Storsjö [this message]
2023-01-04 15:02 ` Nick Clifton
2023-01-05 2:33 ` Mark Harmstone
2023-01-05 11:01 ` Nick Clifton
2023-01-05 10:45 ` Tamar Christina
2023-01-03 14:14 ` Tamar Christina
2023-01-03 12:53 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b140734-145f-db27-1a7a-c5f4c852aae7@martin.st \
--to=martin@martin.st \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=Tamar.Christina@arm.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
--cc=nickc@redhat.com \
--cc=nightstrike@gmail.com \
--cc=pinskia@gmail.com \
--cc=wej22007@outlook.com \
--cc=zac.walker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).