From: Mark Harmstone <mark@harmstone.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "Tamar Christina" <Tamar.Christina@arm.com>,
"Martin Storsjö" <martin@martin.st>,
"Richard Earnshaw" <Richard.Earnshaw@foss.arm.com>,
NightStrike <nightstrike@gmail.com>,
"wej22007@outlook.com" <wej22007@outlook.com>,
"zac.walker@linaro.org" <zac.walker@linaro.org>,
binutils <binutils@sourceware.org>,
"nickc@redhat.com" <nickc@redhat.com>
Subject: Re: [PATCH 1/8] ld: Rename aarch64pe emulation target to arm64pe
Date: Tue, 3 Jan 2023 19:07:02 +0000 [thread overview]
Message-ID: <f13ef5c9-785d-adc6-dd5f-6e6b535f197d@harmstone.com> (raw)
In-Reply-To: <CA+=Sn1=tcO+iUQaFXp_Wx1WBk83zfFzKLQTuQV-oOMS9U=t0_A@mail.gmail.com>
On 3/1/23 18:33, Andrew Pinski wrote:
> My thoughts. arm64 has always been a bad name and should not be
> referenced anywhere. It is bad that Microsoft and LLVM folks have
> started using it.
> We should be consistent with the elf targets here and use aarch64pe
> and then add an alias just for compatibility reasons with LLVM.
> We should push LLVM folks to the same and everyone over to aarch64
> instead of arm64.
>
> Thanks,
> Andrew Pinski
What would this achieve? To reiterate, this is a string that the compiler passes to the linker. Users wouldn't ever see it unless they're doing some pretty low-level stuff.
I agree with Nick's suggestion, that we keep the patch as it is but add a comment explaining the name to anyone curious. Simplicity is a more important engineering principle than consistency... particularly when the naming scheme isn't consistent anyway.
Mark
next prev parent reply other threads:[~2023-01-03 19:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 2:40 Mark Harmstone
2022-12-30 2:40 ` [PATCH 2/8] Fix size of external_reloc for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 3/8] Skip ELF-specific tests when targeting pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 4/8] Skip big-obj test for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 5/8] Add pe-aarch64 relocations Mark Harmstone
2022-12-30 2:40 ` [PATCH 6/8] Add .secrel32 for pe-aarch64 Mark Harmstone
2022-12-30 2:40 ` [PATCH 7/8] Add aarch64-w64-mingw32 target Mark Harmstone
2022-12-30 2:40 ` [PATCH 8/8] gas: Restore tc_pe_dwarf2_emit_offset for pe-aarch64 Mark Harmstone
2023-01-03 11:54 ` [PATCH 1/8] ld: Rename aarch64pe emulation target to arm64pe Nick Clifton
2023-01-03 11:59 ` NightStrike
2023-01-03 12:09 ` Tamar Christina
2023-01-03 14:08 ` Richard Earnshaw
2023-01-03 14:13 ` Martin Storsjö
2023-01-03 14:54 ` Tamar Christina
2023-01-03 15:51 ` Martin Storsjö
2023-01-03 15:57 ` Tamar Christina
2023-01-03 18:21 ` Mark Harmstone
2023-01-03 18:33 ` Andrew Pinski
2023-01-03 19:07 ` Mark Harmstone [this message]
2023-01-03 19:41 ` Tamar Christina
2023-01-03 20:05 ` Martin Storsjö
2023-01-04 2:38 ` Mark Harmstone
2023-01-04 9:51 ` Nick Clifton
2023-01-04 10:25 ` Martin Storsjö
2023-01-04 10:35 ` Tamar Christina
2023-01-04 11:00 ` Martin Storsjö
2023-01-04 11:08 ` Tamar Christina
2023-01-04 11:36 ` Martin Storsjö
2023-01-04 15:02 ` Nick Clifton
2023-01-05 2:33 ` Mark Harmstone
2023-01-05 11:01 ` Nick Clifton
2023-01-05 10:45 ` Tamar Christina
2023-01-03 14:14 ` Tamar Christina
2023-01-03 12:53 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13ef5c9-785d-adc6-dd5f-6e6b535f197d@harmstone.com \
--to=mark@harmstone.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=Tamar.Christina@arm.com \
--cc=binutils@sourceware.org \
--cc=martin@martin.st \
--cc=nickc@redhat.com \
--cc=nightstrike@gmail.com \
--cc=pinskia@gmail.com \
--cc=wej22007@outlook.com \
--cc=zac.walker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).