From: Jan Beulich <jbeulich@suse.com>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
"Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>,
"Potharla, Rupesh via Binutils" <binutils@sourceware.org>
Subject: Re: [PATCH V2] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5.
Date: Tue, 4 Oct 2022 09:43:07 +0200 [thread overview]
Message-ID: <b23ff13b-613e-fe3a-c54d-38a5ed9ea4db@suse.com> (raw)
In-Reply-To: <DM6PR12MB4219C943049C6D883DEA3E55E7569@DM6PR12MB4219.namprd12.prod.outlook.com>
On 30.09.2022 13:41, Potharla, Rupesh via Binutils wrote:
> [AMD Official Use Only - General]
>
> Hi,
>
> Can you review the code changes and send in your comments/suggestions?
>
> Patch Inline:
> -----------------
Thanks, committed. I'd appreciate though if you could submit patches
just as patches, i.e. not including any further data (like everything
above). That simplifies applying.
Jan
> Skip dwo_id for split dwarf.
> * dwarf2.c (parse_comp_unit): Skip DWO_id for DW_UT_skeleton.
> ---
> bfd/dwarf2.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
> index 4a6a1e40185..364cc9a6480 100644
> --- a/bfd/dwarf2.c
> +++ b/bfd/dwarf2.c
> @@ -4411,13 +4411,23 @@ parse_comp_unit (struct dwarf2_debug *stash,
> if (version < 5)
> addr_size = read_1_byte (abfd, &info_ptr, end_ptr);
>
> - if (unit_type == DW_UT_type)
> + switch (unit_type)
> {
> + case DW_UT_type:
> /* Skip type signature. */
> info_ptr += 8;
>
> /* Skip type offset. */
> info_ptr += offset_size;
> + break;
> +
> + case DW_UT_skeleton:
> + /* Skip DWO_id field. */
> + info_ptr += 8;
> + break;
> +
> + default:
> + break;
> }
>
> if (addr_size > sizeof (bfd_vma))
> --
> 2.25.1
>
> Regards,
> Rupesh P
>
next prev parent reply other threads:[~2022-10-04 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 11:41 Potharla, Rupesh
2022-10-04 7:43 ` Jan Beulich [this message]
2022-10-04 7:47 ` Potharla, Rupesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23ff13b-613e-fe3a-c54d-38a5ed9ea4db@suse.com \
--to=jbeulich@suse.com \
--cc=Bhuvanendra.KumarN@amd.com \
--cc=Hariharan.Parasuraman@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Rupesh.Potharla@amd.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).