* [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags
@ 2023-09-27 14:48 Neal Frager
2023-09-27 15:14 ` Nick Clifton
2023-09-28 20:16 ` Michael Eager
0 siblings, 2 replies; 3+ messages in thread
From: Neal Frager @ 2023-09-27 14:48 UTC (permalink / raw)
To: binutils
Cc: ibai.erkiaga-elorza, nagaraju.mekala, mark.hatle,
sadanand.mutyala, appa.rao.nali, vidhumouli.hunsigida,
luca.ceresoli, Neal Frager
Added support in gas for mlittle-endian and mbig-endian flags
as options.
Updated show usage for MicroBlaze specific assembler options
to include new entries.
This patch has been tested for years of AMD Xilinx Yocto
releases as part of the following patch set:
https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils
Signed-off-by: nagaraju <nagaraju.mekala@amd.com>
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- removed new options which were unnecessary
- added documentation for MicroBlaze specific options
---
gas/config/tc-microblaze.c | 5 +++++
gas/doc/as.texi | 2 +-
gas/doc/c-microblaze.texi | 16 ++++++++++++++++
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/gas/config/tc-microblaze.c b/gas/config/tc-microblaze.c
index 564e0b786e2..aa85174befd 100644
--- a/gas/config/tc-microblaze.c
+++ b/gas/config/tc-microblaze.c
@@ -1854,6 +1854,8 @@ struct option md_longopts[] =
{
{"EB", no_argument, NULL, OPTION_EB},
{"EL", no_argument, NULL, OPTION_EL},
+ {"mlittle-endian", no_argument, NULL, OPTION_EL},
+ {"mbig-endian", no_argument, NULL, OPTION_EB},
{ NULL, no_argument, NULL, 0}
};
@@ -2524,6 +2526,9 @@ md_show_usage (FILE * stream ATTRIBUTE_UNUSED)
/* fprintf(stream, _("\
MicroBlaze options:\n\
-noSmall Data in the comm and data sections do not go into the small data section\n")); */
+ fprintf (stream, _(" MicroBlaze specific assembler options:\n"));
+ fprintf (stream, " -%-23s%s\n", "mbig-endian", N_("assemble for a big endian cpu"));
+ fprintf (stream, " -%-23s%s\n", "mlittle-endian", N_("assemble for a little endian cpu"));
}
diff --git a/gas/doc/as.texi b/gas/doc/as.texi
index 6a3e5eed39f..52571d95dd2 100644
--- a/gas/doc/as.texi
+++ b/gas/doc/as.texi
@@ -439,7 +439,7 @@ gcc(1), ld(1), and the Info entries for @file{binutils} and @file{ld}.
@end ifset
@ifset MICROBLAZE
@emph{Target MICROBLAZE options:}
-@c MicroBlaze has no machine-dependent assembler options.
+ [@b{-mlittle-endian}] [@b{-mbig-endian}]
@end ifset
@ifset MIPS
diff --git a/gas/doc/c-microblaze.texi b/gas/doc/c-microblaze.texi
index fabc5ba54df..a76897861f7 100644
--- a/gas/doc/c-microblaze.texi
+++ b/gas/doc/c-microblaze.texi
@@ -22,6 +22,7 @@ Reference Guide (UG081)} available at www.xilinx.com.
@menu
* MicroBlaze Directives:: Directives for MicroBlaze Processors.
* MicroBlaze Syntax:: Syntax for the MicroBlaze
+* MicroBlaze Options:: Options for MicroBlaze Processors.
@end menu
@node MicroBlaze Directives
@@ -97,3 +98,18 @@ preprocessor control command (@pxref{Preprocessing}).
@cindex MicroBlaze line separator
The @samp{;} character can be used to separate statements on the same
line.
+
+@node MicroBlaze Options
+@section Options
+
+MicroBlaze processors support the following options:
+
+@cindex MicroBlaze Options
+
+@table
+@item -mbig-endian
+Build for MicroBlaze in Big Endian configuration.
+
+@item -mlittle-endian
+Build for MicroBlaze in Little Endian configuration.
+@end table
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags
2023-09-27 14:48 [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags Neal Frager
@ 2023-09-27 15:14 ` Nick Clifton
2023-09-28 20:16 ` Michael Eager
1 sibling, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2023-09-27 15:14 UTC (permalink / raw)
To: Neal Frager, binutils
Cc: ibai.erkiaga-elorza, nagaraju.mekala, mark.hatle,
sadanand.mutyala, appa.rao.nali, vidhumouli.hunsigida,
luca.ceresoli
Hi Neal,
> Added support in gas for mlittle-endian and mbig-endian flags
> as options.
>
> Updated show usage for MicroBlaze specific assembler options
> to include new entries.
>
> This patch has been tested for years of AMD Xilinx Yocto
> releases as part of the following patch set:
>
> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils
>
> Signed-off-by: nagaraju <nagaraju.mekala@amd.com>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags
2023-09-27 14:48 [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags Neal Frager
2023-09-27 15:14 ` Nick Clifton
@ 2023-09-28 20:16 ` Michael Eager
1 sibling, 0 replies; 3+ messages in thread
From: Michael Eager @ 2023-09-28 20:16 UTC (permalink / raw)
To: Neal Frager, binutils
Cc: ibai.erkiaga-elorza, nagaraju.mekala, mark.hatle,
sadanand.mutyala, appa.rao.nali, vidhumouli.hunsigida,
luca.ceresoli
On 9/27/23 07:48, Neal Frager via Binutils wrote:
> Added support in gas for mlittle-endian and mbig-endian flags
> as options.
>
> Updated show usage for MicroBlaze specific assembler options
> to include new entries.
>
> This patch has been tested for years of AMD Xilinx Yocto
> releases as part of the following patch set:
>
> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils
>
> Signed-off-by: nagaraju <nagaraju.mekala@amd.com>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - removed new options which were unnecessary
> - added documentation for MicroBlaze specific options
> ---
> gas/config/tc-microblaze.c | 5 +++++
> gas/doc/as.texi | 2 +-
> gas/doc/c-microblaze.texi | 16 ++++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/gas/config/tc-microblaze.c b/gas/config/tc-microblaze.c
> index 564e0b786e2..aa85174befd 100644
> --- a/gas/config/tc-microblaze.c
> +++ b/gas/config/tc-microblaze.c
> @@ -1854,6 +1854,8 @@ struct option md_longopts[] =
> {
> {"EB", no_argument, NULL, OPTION_EB},
> {"EL", no_argument, NULL, OPTION_EL},
> + {"mlittle-endian", no_argument, NULL, OPTION_EL},
> + {"mbig-endian", no_argument, NULL, OPTION_EB},
> { NULL, no_argument, NULL, 0}
> };
>
> @@ -2524,6 +2526,9 @@ md_show_usage (FILE * stream ATTRIBUTE_UNUSED)
> /* fprintf(stream, _("\
> MicroBlaze options:\n\
> -noSmall Data in the comm and data sections do not go into the small data section\n")); */
> + fprintf (stream, _(" MicroBlaze specific assembler options:\n"));
> + fprintf (stream, " -%-23s%s\n", "mbig-endian", N_("assemble for a big endian cpu"));
> + fprintf (stream, " -%-23s%s\n", "mlittle-endian", N_("assemble for a little endian cpu"));
> }
>
>
> diff --git a/gas/doc/as.texi b/gas/doc/as.texi
> index 6a3e5eed39f..52571d95dd2 100644
> --- a/gas/doc/as.texi
> +++ b/gas/doc/as.texi
> @@ -439,7 +439,7 @@ gcc(1), ld(1), and the Info entries for @file{binutils} and @file{ld}.
> @end ifset
> @ifset MICROBLAZE
> @emph{Target MICROBLAZE options:}
> -@c MicroBlaze has no machine-dependent assembler options.
> + [@b{-mlittle-endian}] [@b{-mbig-endian}]
> @end ifset
> @ifset MIPS
>
> diff --git a/gas/doc/c-microblaze.texi b/gas/doc/c-microblaze.texi
> index fabc5ba54df..a76897861f7 100644
> --- a/gas/doc/c-microblaze.texi
> +++ b/gas/doc/c-microblaze.texi
> @@ -22,6 +22,7 @@ Reference Guide (UG081)} available at www.xilinx.com.
> @menu
> * MicroBlaze Directives:: Directives for MicroBlaze Processors.
> * MicroBlaze Syntax:: Syntax for the MicroBlaze
> +* MicroBlaze Options:: Options for MicroBlaze Processors.
> @end menu
>
> @node MicroBlaze Directives
> @@ -97,3 +98,18 @@ preprocessor control command (@pxref{Preprocessing}).
> @cindex MicroBlaze line separator
> The @samp{;} character can be used to separate statements on the same
> line.
> +
> +@node MicroBlaze Options
> +@section Options
> +
> +MicroBlaze processors support the following options:
> +
> +@cindex MicroBlaze Options
> +
> +@table
This should be
@table @code
(See similar text in c-mips.texi, for example.)
> +@item -mbig-endian
> +Build for MicroBlaze in Big Endian configuration.
> +
> +@item -mlittle-endian
> +Build for MicroBlaze in Little Endian configuration.
> +@end table
Did you rebuild the docs with this updated patch? You should have
gotten an error message from MAKEINFO.
Committed with above change.
--
Michael Eager
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-28 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-27 14:48 [PATCH v2 1/1] gas: microblaze: Add mlittle-endian and mbig-endian flags Neal Frager
2023-09-27 15:14 ` Nick Clifton
2023-09-28 20:16 ` Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).