From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: gprofng patch to review
Date: Mon, 14 Nov 2022 10:38:01 -0800 [thread overview]
Message-ID: <b71ed36c-7bc4-d033-dfd4-d9ec6973f9b9@oracle.com> (raw)
In-Reply-To: <DM8PR11MB5749D9053764C6596458BDCDDE059@DM8PR11MB5749.namprd11.prod.outlook.com>
Hello Markus,
On 11/14/22 03:22, Metzger, Markus T wrote:
>> +#ifdef DBG_LT1
>> TprintfT (DBG_LT1, "my_cpuid: __get_cpuid(0x%x, 0x%x, 0x%x, 0x%x,
>> 0x%x) returns %d\n",
>> op, regs->eax, regs->ebx, regs->ecx, regs->edx, ret);
>> +#endif
>>
>>
>>
>> I suggest to just remove TprintfT. This debug output is currently not
>> used by anyone.
> There are other Tprintf (no trailing T) in the ARM part. I didn't touch those
> as it didn't fail on my box and I wouldn't be able to test the changes.
>
> Do you want me to remove those, too? Untested.
yes. Please remove those too.
Your Arm build will fail if you use this file.
Thank you,
-Vladimir
next prev parent reply other threads:[~2022-11-14 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <603d55a9-e789-11e7-2cf0-1fde08874cdf@oracle.com>
2022-11-09 18:50 ` Vladimir Mezentsev
2022-11-14 11:22 ` Metzger, Markus T
2022-11-14 18:38 ` Vladimir Mezentsev [this message]
2022-11-14 18:50 ` Metzger, Markus T
2022-11-14 19:11 ` Vladimir Mezentsev
2022-11-16 10:07 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71ed36c-7bc4-d033-dfd4-d9ec6973f9b9@oracle.com \
--to=vladimir.mezentsev@oracle.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).