public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Jens Remus <jremus@linux.ibm.com>, binutils@sourceware.org
Cc: Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [PATCH v2 5/6] s390: Add missing extended mnemonics
Date: Thu, 23 Nov 2023 11:59:56 +0000	[thread overview]
Message-ID: <b9e1e68e-1ed5-4d27-9db6-6626c989dd8e@redhat.com> (raw)
In-Reply-To: <20231122160752.1351106-1-jremus@linux.ibm.com>

Hi Jens,

> opcodes/
> 	* s390-opc.c: Define operand formats R_CP16_28, U6_18, and
> 	  U5_27. Define instruction formats RIE_RRUUU3, RIE_RRUUU4,
> 	  and RRF_R0RR4.
> 	* s390-opc.txt: Add extended mnemonics jc, jcth, lfi, llgfi,
> 	  llghi, notgr, notr, risbhgz, risblgz, rnsbgt, rosbgt, and
> 	  rxsbgt.
> 
> gas/
> 	* config/tc-s390.c: Add support to insert operand for format
> 	  R_CP16_28, reusing existing logic for format V_CP16_12.
> 	* testsuite/gas/s390/esa-g5.s: Add test for extended mnemonic
> 	  jc.
> 	* testsuite/gas/s390/esa-g5.d: Likewise.
> 	* testsuite/gas/s390/zarch-z900.s: Add test for extended
> 	  mnemonic llghi.
> 	* testsuite/gas/s390/zarch-z900.d: Likewise.
> 	* testsuite/gas/s390/zarch-z9-109.s: Add tests for extended
> 	  mnemonics lfi and llgfi.
> 	* testsuite/gas/s390/zarch-z9-109.d: Likewise.
> 	* testsuite/gas/s390/zarch-z10.s: Add tests for extended
> 	  mnemonics rnsbgt, rosbgt, and rxsbgt.
> 	* testsuite/gas/s390/zarch-z10.d: Likewise.
> 	* testsuite/gas/s390/zarch-z196.s: Add tests for extended
> 	  mnemonics jcth, risbhgz, and risblgz.
> 	* testsuite/gas/s390/zarch-z196.d: Likewise.
> 	* testsuite/gas/s390/zarch-arch13.s: Add tests for extended
> 	  mnemonics notr and notgr.
> 	* testsuite/gas/s390/zarch-arch13.d: Likewise.
> 
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>

Approved - please apply.

Cheers
   Nick



  reply	other threads:[~2023-11-23 11:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 14:06 [PATCH 0/6] " Jens Remus
2023-11-20 14:06 ` [PATCH 1/6] s390: Position independent verification of relative addressing Jens Remus
2023-11-20 14:06 ` [PATCH 2/6] s390: Add brasl edge test cases from ESA to z/Architecture Jens Remus
2023-11-20 14:06 ` [PATCH 3/6] s390: Make operand table indices relative to each other Jens Remus
2023-11-20 14:06 ` [PATCH 4/6] s390: Align optional operand definition to specs Jens Remus
2023-11-22 16:06   ` [PATCH v2 " Jens Remus
2023-11-23 11:58     ` Nick Clifton
2023-11-20 14:06 ` [PATCH 5/6] s390: Add missing extended mnemonics Jens Remus
2023-11-22 16:07   ` [PATCH v2 " Jens Remus
2023-11-23 11:59     ` Nick Clifton [this message]
2023-11-20 14:06 ` [PATCH 6/6] s390: Correct prno instruction name Jens Remus
2023-11-22 12:13 ` [PATCH 0/6] s390: Add missing extended mnemonics Nick Clifton
2023-11-22 16:25   ` Jens Remus
2023-11-23 14:53     ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9e1e68e-1ed5-4d27-9db6-6626c989dd8e@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=jremus@linux.ibm.com \
    --cc=krebbel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).