Re: [PATCH 0/6] s390: Add missing extended mnemonics

[Nick Clifton <nickc@redhat.com>]

Hi Jens,

> This patch series adds the following extended mnemonics (grouped by
> function) to the s390 target architecture:
> - jc, jcth
> - lfi, llgfi, llghi
> - notr, notgr
> - risbhgz, risblgz
> - rnsbgt, rosbgt, rxsbgt
> 
> Additionally the patch series aligns the definition of optional last
> operands to the specification in the z/Architecture Principles of
> Operation. Option optparm is added to the following existing (extended)
> mnemonics:
> - risbg, risbgz, risbgn, risbgnz
> - risbhg, risblg
> - rnsbg, rosbg, rxsbg
> 
> Patches 1-3 are preparatory changes. Patch 4 aligns the optional operand
> definition. Patch 5 adds the missing extended mnemonics. Patch 6 corrects
> an instruction name.
> 
> Patch 1 implements an enhancement to use regular expressions with back
> references to validate the disassembly of instructions with relative
> addressing. This removes the need to update most relative addresses in
> the golden master files the disassembly is checked against when
> inserting new tests.
> 
> Patch 3 enhances the definition of the operand indices, so that new
> operands can be inserted into the operand table without having to
> renumber any indices. This minimizes future hunks that insert new
> operands, such as those introduced by patch 5.

Patch series approved - please apply.

Do these new instructions have a name to cover them as a whole ?
I am thinking that it would be nice to have an entry in the gas/NEWS
file that says something like "add support for the XXX extension to the
s390x architecture".

One other, minor thing.  I tried to look at the documentation that
you referenced in patch 5:

 > Add extended mnemonics specified in the z/Architecture Principles of
 > Operation [1] and z/Architecture Reference Summary [2], that were
 > previously missing from the opcode table.

 > [1] IBM z/Architecture Principles of Operation, SA22-7832-13,
 >    https://www.ibm.com/support/pages/zarchitecture-principles-operation
 > [2] IBM z/Architecture Reference Summary, SA22-7871-11,
 >    https://www.ibm.com/support/pages/zarchitecture-reference-summary

I found that link [2] diverts to a "500: Internal Server Error" page
and link [1] would not let me download the document without first
registering for an IBMid, which I can do, but it is not really Open
Source friendly...

Cheers
   Nick