From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: Jan Beulich <jbeulich@suse.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] gprofng/testsuite: restrict testing to native configurations
Date: Tue, 20 Dec 2022 09:37:06 -0800 [thread overview]
Message-ID: <c922e075-8f61-896c-2748-abbcaf1ef6c4@oracle.com> (raw)
In-Reply-To: <f8cae085-3ed5-a6ec-cedf-f78d0c4b0ae1@suse.com>
LGTM.
Thank you for the gprofng improvement.
-Vladimir
On 12/19/22 07:06, Jan Beulich wrote:
> The binaries involved in testing gprofng are native ones, and hence a
> cross build of binutils won't really test intended functionality. Since
> this testing takes quite a bit of time (typically more than running all
> of binutils, gas, and ld testsuites together), restrict the testing to
> native configurations only.
>
> --- a/gprofng/testsuite/gprofng.display/display.exp
> +++ b/gprofng/testsuite/gprofng.display/display.exp
> @@ -24,6 +24,13 @@ if {[info exists env(LC_ALL)]} {
> set env(LC_ALL) "C"
>
> set pltf [exec uname -i]
> +
> +# Native testing only for now.
> +if { ![istarget $pltf-*-*]
> + && (![string match i?86 $pltf] || ![istarget i?86-*-*]) } then {
> + return
> +}
> +
> switch $pltf {
> x86_64 {
> # Columns in the table represent:
prev parent reply other threads:[~2022-12-20 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 15:06 Jan Beulich
2022-12-20 17:37 ` Vladimir Mezentsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c922e075-8f61-896c-2748-abbcaf1ef6c4@oracle.com \
--to=vladimir.mezentsev@oracle.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).