* [PATCH] gprofng/testsuite: restrict testing to native configurations
@ 2022-12-19 15:06 Jan Beulich
2022-12-20 17:37 ` Vladimir Mezentsev
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-12-19 15:06 UTC (permalink / raw)
To: Binutils; +Cc: Vladimir Mezentsev
The binaries involved in testing gprofng are native ones, and hence a
cross build of binutils won't really test intended functionality. Since
this testing takes quite a bit of time (typically more than running all
of binutils, gas, and ld testsuites together), restrict the testing to
native configurations only.
--- a/gprofng/testsuite/gprofng.display/display.exp
+++ b/gprofng/testsuite/gprofng.display/display.exp
@@ -24,6 +24,13 @@ if {[info exists env(LC_ALL)]} {
set env(LC_ALL) "C"
set pltf [exec uname -i]
+
+# Native testing only for now.
+if { ![istarget $pltf-*-*]
+ && (![string match i?86 $pltf] || ![istarget i?86-*-*]) } then {
+ return
+}
+
switch $pltf {
x86_64 {
# Columns in the table represent:
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] gprofng/testsuite: restrict testing to native configurations
2022-12-19 15:06 [PATCH] gprofng/testsuite: restrict testing to native configurations Jan Beulich
@ 2022-12-20 17:37 ` Vladimir Mezentsev
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Mezentsev @ 2022-12-20 17:37 UTC (permalink / raw)
To: Jan Beulich, Binutils
LGTM.
Thank you for the gprofng improvement.
-Vladimir
On 12/19/22 07:06, Jan Beulich wrote:
> The binaries involved in testing gprofng are native ones, and hence a
> cross build of binutils won't really test intended functionality. Since
> this testing takes quite a bit of time (typically more than running all
> of binutils, gas, and ld testsuites together), restrict the testing to
> native configurations only.
>
> --- a/gprofng/testsuite/gprofng.display/display.exp
> +++ b/gprofng/testsuite/gprofng.display/display.exp
> @@ -24,6 +24,13 @@ if {[info exists env(LC_ALL)]} {
> set env(LC_ALL) "C"
>
> set pltf [exec uname -i]
> +
> +# Native testing only for now.
> +if { ![istarget $pltf-*-*]
> + && (![string match i?86 $pltf] || ![istarget i?86-*-*]) } then {
> + return
> +}
> +
> switch $pltf {
> x86_64 {
> # Columns in the table represent:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-20 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-19 15:06 [PATCH] gprofng/testsuite: restrict testing to native configurations Jan Beulich
2022-12-20 17:37 ` Vladimir Mezentsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).