From: WANG Xuerui <i.swmail@xen0n.name>
To: Youling Tang <tangyouling@loongson.cn>,
WANG Xuerui <i.swmail@xen0n.name>
Cc: binutils@sourceware.org, Chenghua Xu <xuchenghua@loongson.cn>,
Zhensong Liu <liuzhensong@loongson.cn>
Subject: Re: [PATCH] bfd: Add support for LoongArch64 EFI (efi-*-loongarch64).
Date: Fri, 5 Aug 2022 18:22:01 +0800 [thread overview]
Message-ID: <ce4eb3f6-e78b-0fac-a8ba-0429ea00238f@xen0n.name> (raw)
In-Reply-To: <b70f4c62-3d8f-2b43-3a0e-599d9ea77515@loongson.cn>
On 2022/8/5 18:07, Youling Tang wrote:
> Hi, Xuerui
>
> On 08/05/2022 05:41 PM, WANG Xuerui wrote:
>> <snip>
>>
>> +#define COFF_IMAGE_WITH_PE
>> +/* Rename the above into.. */
>> I know this is copied from bfd/pei-aarch64.c, but you could reformat it
>> a little by adding an additional period and space, for style
>> consistency.
> In the previous macro definition, I used tab alignment. Do you want to
> use space alignment?
Sorry I meant only the comment line directly above. I can't check
tab/space usage on Thunderbird because whitespaces can't be made visible
like with VSCode/Vim AFAIK.
> <snip>
>>> diff --git a/binutils/NEWS b/binutils/NEWS
>>> index 4fdf1c3b4e8..3b5a96b9819 100644
>>> --- a/binutils/NEWS
>>> +++ b/binutils/NEWS
>>> @@ -14,6 +14,9 @@ Changes in 2.39:
>>> architectures. Use the --disassembler-color=MODE command line
>>> flag, with
>>> mode being either off, color, or extended-color.
>>> +* Support for pei-loongarch64 has been added to objcopy in order to
>>> enable
>>> + UEFI development using binutils.
>>> +
>> Isn't binutils 2.39 already frozen?
> I will add to the next version.
Okay. (I don't know if just adding a "Changes in 2.40:" heading would
suffice, or if something else has to be done, though.)
prev parent reply other threads:[~2022-08-05 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:26 Youling Tang
2022-08-05 9:41 ` WANG Xuerui
2022-08-05 10:07 ` Youling Tang
2022-08-05 10:22 ` WANG Xuerui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4eb3f6-e78b-0fac-a8ba-0429ea00238f@xen0n.name \
--to=i.swmail@xen0n.name \
--cc=binutils@sourceware.org \
--cc=liuzhensong@loongson.cn \
--cc=tangyouling@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).