* [PATCH] binutils: Fix calloc argument order in srconv.c
@ 2024-01-21 23:50 Mark Wielaard
2024-01-22 17:16 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2024-01-21 23:50 UTC (permalink / raw)
To: binutils; +Cc: Mark Wielaard
GCC 14 will warn about calling calloc with swapped size and count
arguments.
binutils/srconv.c: In function ‘nints’:
binutils/srconv.c:598:36: error: ‘xcalloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
598 | return (int *) (xcalloc (sizeof (int), x));
| ^~~
binutils/srconv.c:598:36: note: earlier argument should specify number of elements, later size of each element
binutils/
* srconv.c (nints): Swap xcalloc arguments.
(wr_du): Likewise.
(wr_dus): Likewise.
---
binutils/srconv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/binutils/srconv.c b/binutils/srconv.c
index 1ff68fa08b0..7e22f7a0d4f 100644
--- a/binutils/srconv.c
+++ b/binutils/srconv.c
@@ -595,7 +595,7 @@ wr_dps_end (struct coff_section *section ATTRIBUTE_UNUSED,
static int *
nints (int x)
{
- return (int *) (xcalloc (sizeof (int), x));
+ return (int *) (xcalloc (x, sizeof (int)));
}
static void
@@ -1183,7 +1183,7 @@ wr_du (struct coff_ofile *p, struct coff_sfile *sfile, int n)
du.spare = 0;
du.unit = n;
du.sections = p->nsections - 1;
- du.san = (int *) xcalloc (sizeof (int), du.sections);
+ du.san = (int *) xcalloc (du.sections, sizeof (int));
du.address = nints (du.sections);
du.length = nints (du.sections);
@@ -1242,7 +1242,7 @@ wr_dus (struct coff_ofile *p ATTRIBUTE_UNUSED, struct coff_sfile *sfile)
dus.efn = 0x1001;
dus.ns = 1; /* p->nsources; sac 14 jul 94 */
dus.drb = nints (dus.ns);
- dus.fname = (char **) xcalloc (sizeof (char *), dus.ns);
+ dus.fname = (char **) xcalloc (dus.ns, sizeof (char *));
dus.spare = nints (dus.ns);
dus.ndir = 0;
/* Find the filenames. */
--
2.39.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] binutils: Fix calloc argument order in srconv.c
2024-01-21 23:50 [PATCH] binutils: Fix calloc argument order in srconv.c Mark Wielaard
@ 2024-01-22 17:16 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-01-22 17:16 UTC (permalink / raw)
To: Mark Wielaard, binutils
Hi Mark,
> GCC 14 will warn about calling calloc with swapped size and count
> arguments.
> binutils/
>
> * srconv.c (nints): Swap xcalloc arguments.
> (wr_du): Likewise.
> (wr_dus): Likewise.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-22 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-21 23:50 [PATCH] binutils: Fix calloc argument order in srconv.c Mark Wielaard
2024-01-22 17:16 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).