[PATCH] x86: Fix indentation and use true/false instead of 1/0

[PATCH] x86: Fix indentation and use true/false instead of 1/0

[Cui, Lili]

   This patch is to Fix indentation and use true/false instead of 1/0.

Regards,
Lili.

gas/ChangeLog:

        * config/tc-i386.c (establish_rex): Fix indentation.
        (check_EgprOperands): Use true/false instead of 1/0.
---
 gas/config/tc-i386.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index d599306b12c..856edbe557c 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -4300,7 +4300,7 @@ static void establish_rex (void)
 	}
     }
 
-   if (i.rex == 0 && i.rex2 == 0 && (i.rex_encoding || i.rex2_encoding))
+  if (i.rex == 0 && i.rex2 == 0 && (i.rex_encoding || i.rex2_encoding))
     {
       /* Check if we can add a REX_OPCODE byte.  Look for 8 bit operand
 	 that uses legacy register.  If it is "hi" register, don't add
@@ -4323,14 +4323,14 @@ static void establish_rex (void)
 	i.rex = REX_OPCODE;
     }
 
-   if (is_apx_rex2_encoding ())
-     {
-       build_rex2_prefix ();
-       /* The individual REX.RXBW bits got consumed.  */
-       i.rex &= REX_OPCODE;
-     }
-   else if (i.rex != 0)
-     add_prefix (REX_OPCODE | i.rex);
+  if (is_apx_rex2_encoding ())
+    {
+      build_rex2_prefix ();
+      /* The individual REX.RXBW bits got consumed.  */
+      i.rex &= REX_OPCODE;
+    }
+  else if (i.rex != 0)
+    add_prefix (REX_OPCODE | i.rex);
 }
 
 static void
@@ -7197,7 +7197,7 @@ static bool
 check_EgprOperands (const insn_template *t)
 {
   if (!t->opcode_modifier.noegpr)
-    return 0;
+    return false;
 
   for (unsigned int op = 0; op < i.operands; op++)
     {
@@ -7207,7 +7207,7 @@ check_EgprOperands (const insn_template *t)
       if (i.op[op].regs->reg_flags & RegRex2)
 	{
 	  i.error = register_type_mismatch;
-	  return 1;
+	  return true;
 	}
     }
 
@@ -7215,17 +7215,17 @@ check_EgprOperands (const insn_template *t)
       || (i.base_reg && (i.base_reg->reg_flags & RegRex2)))
     {
       i.error = unsupported_EGPR_for_addressing;
-      return 1;
+      return true;
     }
 
   /* Check if pseudo prefix {rex2} is valid.  */
   if (i.rex2_encoding)
     {
       i.error = invalid_pseudo_prefix;
-      return 1;
+      return true;
     }
 
-  return 0;
+  return false;
 }
 
 /* Check if APX operands are valid for the instruction.  */
-- 
2.25.1

Re: [PATCH] x86: Fix indentation and use true/false instead of 1/0

[Jan Beulich]

On 11.01.2024 10:22, Cui, Lili wrote:
>    This patch is to Fix indentation and use true/false instead of 1/0.
> 
> Regards,
> Lili.
> 
> gas/ChangeLog:
> 
>         * config/tc-i386.c (establish_rex): Fix indentation.
>         (check_EgprOperands): Use true/false instead of 1/0.

Okay and thanks.

Jan