From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2] IBM zSystems: Accept (. - 0x100000000) PCRel32 operands
Date: Mon, 9 May 2022 07:44:15 +0200 [thread overview]
Message-ID: <d027564f-e8e0-4885-687f-db789797ffd9@linux.ibm.com> (raw)
In-Reply-To: <20220504103648.1724970-1-iii@linux.ibm.com>
On 5/4/22 12:36, Ilya Leoshkevich wrote:
> as does not accept instructions like brasl %r0,.-0x100000000, because
> of two problems with the generic overflow check:
>
> 1. PCRel32 operands are signed, but are treated as unsigned.
>
> 2. The allowed range for these operands is [-(1 << 32), (1 << 32) - 1],
> and not [-(1 << 31), (1 << 31) - 1].
>
> Fix both by disabling the generic overflow check - it's not needed,
> because s390_insert_operand () performs its own.
>
> gas/ChangeLog:
>
> * config/tc-s390.c (md_gather_operands): Set fx_no_overflow.
> * testsuite/gas/s390/s390.exp: Add zarch-z900-err.
> * testsuite/gas/s390/esa-z900.d: New test.
> * testsuite/gas/s390/esa-z900.s: New test.
> * testsuite/gas/s390/zarch-z900-err.l: New test.
> * testsuite/gas/s390/zarch-z900-err.s: New test.
Ok. Thanks!
Andreas
next prev parent reply other threads:[~2022-05-09 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 10:36 Ilya Leoshkevich
2022-05-09 5:44 ` Andreas Krebbel [this message]
2022-05-09 20:01 ` Andreas Krebbel
2022-05-12 2:55 ` Alan Modra
2022-05-12 12:33 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d027564f-e8e0-4885-687f-db789797ffd9@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=binutils@sourceware.org \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).