Re: [PATCH] LoongArch: Fix a bug of getting relocation type

[mengqinggang <mengqinggang@loongson.cn>]

Hi Nick,

This patch and

969f5c0e1        LoongArch: gas: Add support for s9 register
a0aa6f4ab        LoongArch: ld: Add support for TLS LE symbol with addend

need to apply to 2.42 branch.


在 2024/1/26 上午11:39, mengqinggang 写道:
> The old code works because R_LARCH_RELAX has no symbol index. It causes
> '(rel + 1)->r_info == R_LARCH_RELAX' is 1 and ELFNN_R_TYPE (1) is 1.
> ---
>   bfd/elfnn-loongarch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index b2caa5fc3e1..0cc6273726c 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -4166,7 +4166,7 @@ loongarch_relax_tls_le (bfd *abfd, asection *sec,
>     static uint32_t insn_rj,insn_rd;
>     symval = symval - elf_hash_table (link_info)->tls_sec->vma;
>     /* Whether the symbol offset is in the interval (offset < 0x800).  */
> -  if (ELFNN_R_TYPE ((rel + 1)->r_info == R_LARCH_RELAX) && (symval < 0x800))
> +  if (ELFNN_R_TYPE ((rel + 1)->r_info) == R_LARCH_RELAX && (symval < 0x800))
>       {
>         switch (ELFNN_R_TYPE (rel->r_info))
>   	{