From: Nick Clifton <nickc@redhat.com>
To: "Luis Machado" <luis.machado@arm.com>,
"Clément Chigot" <chigot@adacore.com>,
binutils@sourceware.org
Cc: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
Subject: Re: [PATCH] bfd: handle codepage when opening files on MinGW
Date: Mon, 15 Aug 2022 12:07:48 +0100 [thread overview]
Message-ID: <d09b8bff-db06-27da-554c-70b5232a5756@redhat.com> (raw)
In-Reply-To: <2fe3fe60-4039-b9e8-4212-4d9f62e270cc@arm.com>
Hi Luis,
> In fact, trying to build master binutils-gdb with Ubuntu 22.04's mingw-w64 8.0 or Ubuntu 20.04's mingw-w64 7.0.0 runs
> into the following:
>
> bfd/bfdio.c: In function ‘_bfd_real_fopen’:
> bfd/bfdio.c:125:28: error: implicit declaration of function ‘___lc_codepage_func’ [-Werror=implicit-function-declaration]
> 125 | const unsigned int cp = ___lc_codepage_func();
So that would imply a missing #include of a system header, yes ?
Do you know which header provides the required prototype ?
The code is currently conditional upon __MINGW32__ being defined. Perhaps
that check needs to be extended/changed to reference a different preprocessor
symbol ?
Cheers
Nick
next prev parent reply other threads:[~2022-08-15 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 7:27 Clément Chigot
2022-06-28 7:47 ` Clément Chigot
2022-06-28 14:52 ` Nick Clifton
2022-08-12 14:45 ` Luis Machado
2022-08-12 15:11 ` Clément Chigot
2022-08-12 15:13 ` Luis Machado
2022-08-15 11:07 ` Nick Clifton [this message]
2022-08-15 11:38 ` Torbjorn SVENSSON
2022-08-16 12:15 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09b8bff-db06-27da-554c-70b5232a5756@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
--cc=luis.machado@arm.com \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).