* [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A.
@ 2022-05-16 16:10 Tamar Christina
2022-05-17 9:56 ` Richard Earnshaw
0 siblings, 1 reply; 5+ messages in thread
From: Tamar Christina @ 2022-05-16 16:10 UTC (permalink / raw)
To: binutils; +Cc: nd, Richard.Earnshaw, marcus.shawcroft
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
Hi All,
In Armv9-A SVE is mandatory, and for SVE FP16 is mandatory. This fixes a disconnect
between GCC and binutils where GCC has FP16 on by default and gas doesn't.
build on native hardware and regtested on aarch64-none-linux-gnu and no issues.
Ok for master? and for backport to binutils-2.38?
Thanks,
Tamar
include/ChangeLog:
2022-05-16 Tamar Christina <tamar.christina@arm.com>
* opcode/aarch64.h (AARCH64_ARCH_V9_FEATURES): Add AARCH64_FEATURE_F16.
--- inline copy of patch --
diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index a4912930c8f1e564bec6ec46a649ac1205093bd1..8fe27900cba3e897880a3966cc2a17e89dbdf018 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -140,6 +140,7 @@ typedef uint32_t aarch64_insn;
| AARCH64_FEATURE_HBC)
#define AARCH64_ARCH_V9_FEATURES (AARCH64_FEATURE_V9 \
+ | AARCH64_FEATURE_F16 \
| AARCH64_FEATURE_SVE \
| AARCH64_FEATURE_SVE2)
#define AARCH64_ARCH_V9_1_FEATURES (AARCH64_ARCH_V8_6_FEATURES)
--
[-- Attachment #2: rb15727.patch --]
[-- Type: text/plain, Size: 534 bytes --]
diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
index a4912930c8f1e564bec6ec46a649ac1205093bd1..8fe27900cba3e897880a3966cc2a17e89dbdf018 100644
--- a/include/opcode/aarch64.h
+++ b/include/opcode/aarch64.h
@@ -140,6 +140,7 @@ typedef uint32_t aarch64_insn;
| AARCH64_FEATURE_HBC)
#define AARCH64_ARCH_V9_FEATURES (AARCH64_FEATURE_V9 \
+ | AARCH64_FEATURE_F16 \
| AARCH64_FEATURE_SVE \
| AARCH64_FEATURE_SVE2)
#define AARCH64_ARCH_V9_1_FEATURES (AARCH64_ARCH_V8_6_FEATURES)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A.
2022-05-16 16:10 [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A Tamar Christina
@ 2022-05-17 9:56 ` Richard Earnshaw
2022-05-17 10:09 ` Tamar Christina
2022-06-16 13:19 ` Nick Clifton
0 siblings, 2 replies; 5+ messages in thread
From: Richard Earnshaw @ 2022-05-17 9:56 UTC (permalink / raw)
To: Tamar Christina, binutils; +Cc: Richard.Earnshaw, nd, marcus.shawcroft
On 16/05/2022 17:10, Tamar Christina via Binutils wrote:
> Hi All,
>
> In Armv9-A SVE is mandatory, and for SVE FP16 is mandatory. This fixes a disconnect
> between GCC and binutils where GCC has FP16 on by default and gas doesn't.
>
> build on native hardware and regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master? and for backport to binutils-2.38?
>
OK for master. I think you'll need Nick to approve a backport, though.
I would recommend that.
R.
> Thanks,
> Tamar
>
> include/ChangeLog:
>
> 2022-05-16 Tamar Christina <tamar.christina@arm.com>
>
> * opcode/aarch64.h (AARCH64_ARCH_V9_FEATURES): Add AARCH64_FEATURE_F16.
>
> --- inline copy of patch --
> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
> index a4912930c8f1e564bec6ec46a649ac1205093bd1..8fe27900cba3e897880a3966cc2a17e89dbdf018 100644
> --- a/include/opcode/aarch64.h
> +++ b/include/opcode/aarch64.h
> @@ -140,6 +140,7 @@ typedef uint32_t aarch64_insn;
> | AARCH64_FEATURE_HBC)
>
> #define AARCH64_ARCH_V9_FEATURES (AARCH64_FEATURE_V9 \
> + | AARCH64_FEATURE_F16 \
> | AARCH64_FEATURE_SVE \
> | AARCH64_FEATURE_SVE2)
> #define AARCH64_ARCH_V9_1_FEATURES (AARCH64_ARCH_V8_6_FEATURES)
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A.
2022-05-17 9:56 ` Richard Earnshaw
@ 2022-05-17 10:09 ` Tamar Christina
2022-05-18 16:29 ` Nick Clifton
2022-06-16 13:19 ` Nick Clifton
1 sibling, 1 reply; 5+ messages in thread
From: Tamar Christina @ 2022-05-17 10:09 UTC (permalink / raw)
To: Richard Earnshaw, binutils; +Cc: nd, Marcus Shawcroft, nickc
>
> On 16/05/2022 17:10, Tamar Christina via Binutils wrote:
> > Hi All,
> >
> > In Armv9-A SVE is mandatory, and for SVE FP16 is mandatory. This
> > fixes a disconnect between GCC and binutils where GCC has FP16 on by
> default and gas doesn't.
> >
> > build on native hardware and regtested on aarch64-none-linux-gnu and no
> issues.
> >
> > Ok for master? and for backport to binutils-2.38?
> >
>
> OK for master. I think you'll need Nick to approve a backport, though.
> I would recommend that.
>
Ah ok, Nick, permission to backport to 2.38?
Cheers,
Tamar
> R.
>
> > Thanks,
> > Tamar
> >
> > include/ChangeLog:
> >
> > 2022-05-16 Tamar Christina <tamar.christina@arm.com>
> >
> > * opcode/aarch64.h (AARCH64_ARCH_V9_FEATURES): Add
> AARCH64_FEATURE_F16.
> >
> > --- inline copy of patch --
> > diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h index
> >
> a4912930c8f1e564bec6ec46a649ac1205093bd1..8fe27900cba3e897880a3966cc
> 2a
> > 17e89dbdf018 100644
> > --- a/include/opcode/aarch64.h
> > +++ b/include/opcode/aarch64.h
> > @@ -140,6 +140,7 @@ typedef uint32_t aarch64_insn;
> > | AARCH64_FEATURE_HBC)
> >
> > #define AARCH64_ARCH_V9_FEATURES (AARCH64_FEATURE_V9
> \
> > + | AARCH64_FEATURE_F16 \
> > | AARCH64_FEATURE_SVE
> \
> > | AARCH64_FEATURE_SVE2)
> > #define AARCH64_ARCH_V9_1_FEATURES
> (AARCH64_ARCH_V8_6_FEATURES)
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A.
2022-05-17 9:56 ` Richard Earnshaw
2022-05-17 10:09 ` Tamar Christina
@ 2022-06-16 13:19 ` Nick Clifton
1 sibling, 0 replies; 5+ messages in thread
From: Nick Clifton @ 2022-06-16 13:19 UTC (permalink / raw)
To: Richard Earnshaw, Tamar Christina, binutils
Cc: Richard.Earnshaw, nd, marcus.shawcroft
Hi Guys,
>> Ok for master? and for backport to binutils-2.38?
> OK for master. I think you'll need Nick to approve a backport, though. I would recommend that.
Approved for a backport as well.
Cheers
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-16 13:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 16:10 [PATCH][Binutils]AArch64 Enable FP16 by default for Armv9-A Tamar Christina
2022-05-17 9:56 ` Richard Earnshaw
2022-05-17 10:09 ` Tamar Christina
2022-05-18 16:29 ` Nick Clifton
2022-06-16 13:19 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).