From: Jan Beulich <jbeulich@suse.com>
To: Liao Shihua <shihua@iscas.ac.cn>
Cc: kito.cheng@sifive.com, jiawei@iscas.ac.cn, palmer@dabbelt.com,
guoren@kernel.org, wuwei2016@iscas.ac.cn, shiyulong@iscas.ac.cn,
chenyixuan@iscas.ac.cn, binutils@sourceware.org
Subject: Re: [RFC PATCH 1/4] RISC-V : Remove checking when -march=rv64XX and -mabi=ilp32X
Date: Fri, 19 May 2023 08:25:39 +0200 [thread overview]
Message-ID: <d3e8ce1a-c976-5fe2-74b2-2b1960e29f06@suse.com> (raw)
In-Reply-To: <20230519034835.664-2-shihua@iscas.ac.cn>
On 19.05.2023 05:48, Liao Shihua wrote:
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -379,7 +379,7 @@ riscv_set_abi_by_arch (void)
> gas_assert (abi_xlen != 0 && xlen != 0 && float_abi != FLOAT_ABI_DEFAULT);
> if (abi_xlen > xlen)
> as_bad ("can't have %d-bit ABI on %d-bit ISA", abi_xlen, xlen);
> - else if (abi_xlen < xlen)
> + else if (abi_xlen < xlen && (abi_xlen != 32 && xlen != 64))
> as_bad ("%d-bit ABI not yet supported on %d-bit ISA", abi_xlen, xlen);
Did you mean || as the inner operator of the condition you add?
Also I think this change ought to come after patch 2, not first.
Jan
next prev parent reply other threads:[~2023-05-19 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:48 [RFC PATCH V2 0/4] RISC-V : Support ilp32 abi on rv64 isa Liao Shihua
2023-05-19 3:48 ` [RFC PATCH 1/4] RISC-V : Remove checking when -march=rv64XX and -mabi=ilp32X Liao Shihua
2023-05-19 6:25 ` Jan Beulich [this message]
2023-05-19 3:48 ` [RFC PATCH 2/4] RISC-V : Add support for rv64 arch using ilp32 abi Liao Shihua
2023-05-19 6:33 ` Jan Beulich
2023-05-19 6:58 ` shihua
2023-05-19 3:48 ` [RFC PATCH 3/4] RISC-V : Add rv64 ilp32 support in disassemble Liao Shihua
2023-05-25 15:35 ` Guo Ren
2023-05-19 3:48 ` [RFC PATCH 4/4] gdb/riscv : Add rv64 ilp32 support in gdb Liao Shihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e8ce1a-c976-5fe2-74b2-2b1960e29f06@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=chenyixuan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=shihua@iscas.ac.cn \
--cc=shiyulong@iscas.ac.cn \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).