public inbox for
 help / color / mirror / Atom feed
* [PATCH] x86: remove indirection from bx[] and di_si[]
@ 2023-08-14 11:56 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2023-08-14 11:56 UTC (permalink / raw)
  To: Binutils; +Cc: H.J. Lu

The longest register name is 3 characters (plus a nul one), so using a
4- or 8-byte pointer to get at it is neither space nor time efficient.
Embed the names right into the array. For PIE this also slightly reduces
the number of base relocations in the final image.
di_si[], looking at its contents, also is somewhat misnamed, I would

--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -12250,13 +12250,13 @@ i386_index_check (const char *operand_st
       /* Memory operands of string insns are special in that they only allow
 	 a single register (rDI, rSI, or rBX) as their memory address.  */
       const reg_entry *expected_reg;
-      static const char *di_si[][2] =
+      static const char di_si[][2][4] =
 	  { "esi", "edi" },
 	  { "si", "di" },
 	  { "rsi", "rdi" }
-      static const char *bx[] = { "ebx", "bx", "rbx" };
+      static const char bx[][4] = { "ebx", "bx", "rbx" };
       kind = "string address";

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-14 11:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14 11:56 [PATCH] x86: remove indirection from bx[] and di_si[] Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).