From: Jan Beulich <jbeulich@suse.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Jedidiah Thompson <wej22007@outlook.com>,
Zac Walker <zac.walker@linaro.org>,
binutils@sourceware.org
Subject: Re: [PATCH] Remove duplicate pe-dll.o entry deom targ_extra_ofiles
Date: Thu, 19 Jan 2023 10:38:43 +0100 [thread overview]
Message-ID: <e32dde92-4dda-5f62-7423-5a14b5b807ef@suse.com> (raw)
In-Reply-To: <20230119035126.1172654-1-raj.khem@gmail.com>
On 19.01.2023 04:51, Khem Raj via Binutils wrote:
> Commit c60b3806799abf1d7f6cf5108a1b0e733a950b13 added support for
> aarch64-pe which introduced wrapper over pep-dll.c for x86_64 as well as
> aarch64, on x86_64 it was added but the old object pe-dll.o needs to be
> removed too, otherwise build fails with duplicate symbols from pe-dll.o
> and pep-dll-x86_64.o
Prior to said change pe-dll.o and pep-dll.o were also _both_ linked in.
You want to explain why _that_ isn't necessary anymore (if that's really
the case, which I doubt; instead I think your change breaks i386pe as
specified via targ_extra_emuls). Otherwise the duplicate symbol errors
(which, btw, I'm not seeing, so there must be more to it than you say)
need dealing with another way.
Jan
prev parent reply other threads:[~2023-01-19 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 3:51 Khem Raj
2023-01-19 9:38 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32dde92-4dda-5f62-7423-5a14b5b807ef@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=raj.khem@gmail.com \
--cc=wej22007@outlook.com \
--cc=zac.walker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).