From: WANG Xuerui <i.swmail@xen0n.name>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name,
maskray@google.com
Subject: Re: [PATCH v2 0/2] LoongArch: gas: Add LVZ and LBT instructions support
Date: Fri, 30 Jun 2023 17:15:29 +0800 [thread overview]
Message-ID: <edfdfa76-1f78-84f4-6dba-2f46faefc9b4@xen0n.name> (raw)
In-Reply-To: <20230630090416.3051425-1-mengqinggang@loongson.cn>
On 2023/6/30 17:04, mengqinggang wrote:
> Changes from v1:
> Add LARCH_opts.ase_lvz and LARCH_opts.ase_lbt.
>
> mengqinggang (2):
> LoongArch: gas: Add LVZ and LBT instructions support
> LoongArch: gas: Fix code style issues
>
> gas/config/tc-loongarch.c | 4 +
> gas/testsuite/gas/loongarch/lvz-lbt.d | 191 ++
> gas/testsuite/gas/loongarch/lvz-lbt.s | 181 ++
> gas/testsuite/gas/loongarch/uleb128.d | 52 +-
> include/opcode/loongarch.h | 6 +
> opcodes/loongarch-dis.c | 2 +
> opcodes/loongarch-opc.c | 3195 +++++++++++++------------
> 7 files changed, 2105 insertions(+), 1526 deletions(-)
> create mode 100644 gas/testsuite/gas/loongarch/lvz-lbt.d
> create mode 100644 gas/testsuite/gas/loongarch/lvz-lbt.s
>
Thanks for the patches, this now LGTM. (I have to fixup some offset
operands' format strings and it's better done after these are applied.)
For the record: I got off-list confirmation that the "setx86*" and
"setarm*" names won't get changed this time. While reasons were not
given, I believe it's probably because the "setARCH*" ops are actually
markers and do not actually touch arch-specific state, while the
"ARCHset*" ones do; but without the manuals available that's just a wild
guess. We'll have time to revisit anyway without compatibility concerns
though, so I'm fine with the decision at the moment.
prev parent reply other threads:[~2023-06-30 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:04 mengqinggang
2023-06-30 9:04 ` [PATCH v2 1/2] " mengqinggang
2023-06-30 9:04 ` [PATCH v2 2/2] LoongArch: gas: Fix code style issues mengqinggang
2023-06-30 9:15 ` WANG Xuerui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edfdfa76-1f78-84f4-6dba-2f46faefc9b4@xen0n.name \
--to=i.swmail@xen0n.name \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).