public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: YunQiang Su <yunqiang.su@cipunited.com>, binutils@sourceware.org
Cc: amodra@gmail.com
Subject: Re: [PATCH] ld: Use [list ] syntax to define run_tests in indirect.exp
Date: Fri, 7 Jul 2023 09:47:42 +0100	[thread overview]
Message-ID: <f11a5635-6f52-5d10-23c8-29f475cfe868@redhat.com> (raw)
In-Reply-To: <20230630051451.1867944-1-yunqiang.su@cipunited.com>

Hi YunQiang Su,

> Currently, the var run_tests is defined by syntax {{}},
> while in this case, variables cannot be used.
> Thus $NOPIE_CFLAGS and $NOPIE_LDFLAGS are passed to cmd as names
> instead of values:
>    gcc ... $NOPIE_CFLAGS -c .../indirect5a.c -o tmpdir/indirect5a.o
> 
> Let's use [list [list ]] syntax instead.
> 
> ld/ChangeLog:
> 
> 	* testsuite/ld-elf/indirect.exp(run_tests): use [list [list]]
> 	syntax instead of {{}}.

Approved - please apply.

Cheers
   Nick



      parent reply	other threads:[~2023-07-07  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30  5:14 YunQiang Su
2023-07-05 20:57 ` Alan Modra
2023-07-07  8:47 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f11a5635-6f52-5d10-23c8-29f475cfe868@redhat.com \
    --to=nickc@redhat.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).