* [PATCH] MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32
@ 2023-11-24 8:55 YunQiang Su
2024-01-08 14:45 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: YunQiang Su @ 2023-11-24 8:55 UTC (permalink / raw)
To: nickc; +Cc: binutils, YunQiang Su
Currently, only mipsisa32-linux and mipsisa32el-linux is marked
as addr32, which make mipsisa32rN(el) not marked.
This change can fix 2 test failures on mipsisa32rN(el)-linux:
FAIL: MIPS MIPS64 MIPS-3D ASE instructions (-mips3d flag)
FAIL: MIPS MIPS64 MDMX ASE instructions (-mdmx flag)
These failures don't happen for mipsisa32rN-mti-elf etc,
due to that, the output is set as NO_ABI instead of O32, then
gas won't warn:
`fp=64' used with a 32-bit ABI
Maybe, we should change this behaivour in future.
---
gas/testsuite/gas/mips/mips.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index bfcb3cbfaf3..d85db116967 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -564,7 +564,7 @@ if { [istarget mips*-*-vxworks*] } {
"MIPS invalid switch to SVR4 PIC from VxWorks PIC"
} elseif { [istarget mips*-*-*] } {
set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*] \
- || [istarget mipsisa32-*-linux*] || [istarget mipsisa32el-*-linux*]]
+ || [istarget mipsisa32*-*-linux*]]
set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
|| [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*] \
|| [istarget mips*-img-elf*]]
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32
2023-11-24 8:55 [PATCH] MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32 YunQiang Su
@ 2024-01-08 14:45 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-01-08 14:45 UTC (permalink / raw)
To: YunQiang Su; +Cc: binutils
Hi YunQiang,
> Currently, only mipsisa32-linux and mipsisa32el-linux is marked
> as addr32, which make mipsisa32rN(el) not marked.
>
> This change can fix 2 test failures on mipsisa32rN(el)-linux:
> FAIL: MIPS MIPS64 MIPS-3D ASE instructions (-mips3d flag)
> FAIL: MIPS MIPS64 MDMX ASE instructions (-mdmx flag)
Patch approved and applied.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-08 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 8:55 [PATCH] MIPS/GAS: mips.exp, mark all mipsisa32*-linux as addr32 YunQiang Su
2024-01-08 14:45 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).