public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] ld: Fix redundant space in ld.texi
@ 2023-11-13  6:03 Chung-Ju Wu
  2023-11-13 15:34 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Chung-Ju Wu @ 2023-11-13  6:03 UTC (permalink / raw)
  To: Nick Clifton, binutils-patches

Hi Nick,

I just noticed that there may be a space typo in the commit
"f1837d9c3f2dc2a5c232f4eae4c4bd5a7f77baf8" for PR30865:
https://sourceware.org/bugzilla/show_bug.cgi?id=30865

The redundant space between "@samp" and "{0 0 22 23}" at line 5608
causes build fail on my environment with following error message:

binutils-gdb/ld/ld.texi:5608: @samp expected braces.
binutils-gdb/ld/ld.texi:5608: Misplaced {.
binutils-gdb/ld/ld.texi:5608: Misplaced }.
binutils-gdb/ld/ld.texi:5608: @code missing close brace.

Here is the patch to fix it.  Is that OK to commit?

---
  ld/ChangeLog | 4 ++++
  ld/ld.texi   | 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index fc2478ec197..316ef47e93b 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+2023-11-13  Chung-Ju Wu  <jasonwucj@gmail.com>
+
+       * ld.texi: Fix redundant space typo.
+
  2023-11-10  Nick Clifton  <nickc@redhat.com>

         * ldlex.h (enum option_values): Add OPTION_ERROR_EXECSTACK,
diff --git a/ld/ld.texi b/ld/ld.texi
index 32c09e24478..5a143b2b518 100644
--- a/ld/ld.texi
+++ b/ld/ld.texi
@@ -5605,7 +5605,7 @@ bytes when used to fill gaps.  Thus @samp{FILL(144)} will fill a
  region with repeats of the pattern @samp{0 0 0 144}.  The value is
  treated as a big-endian number, so for example
  @samp{FILL(22 * 256 + 23)} will fill the region with repeats of the
-pattern @samp {0 0 22 23}.  If the expression results in a value with
+pattern @samp{0 0 22 23}.  If the expression results in a value with
  more than 4 significant bytes only the least 4 bytes of the value will
  be used.

--


Regards,
jasonwucj


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ld: Fix redundant space in ld.texi
  2023-11-13  6:03 [PATCH] ld: Fix redundant space in ld.texi Chung-Ju Wu
@ 2023-11-13 15:34 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2023-11-13 15:34 UTC (permalink / raw)
  To: Chung-Ju Wu, binutils-patches

Hi Chung-Ju Wu,

> binutils-gdb/ld/ld.texi:5608: @samp expected braces.
> binutils-gdb/ld/ld.texi:5608: Misplaced {.
> binutils-gdb/ld/ld.texi:5608: Misplaced }.
> binutils-gdb/ld/ld.texi:5608: @code missing close brace.

Oops!

> Here is the patch to fix it.  Is that OK to commit?

Patch approved and applied.  Thanks for reporting this.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-13 15:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13  6:03 [PATCH] ld: Fix redundant space in ld.texi Chung-Ju Wu
2023-11-13 15:34 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).