From: Mark Wielaard <mark@klomp.org>
To: Nick Clifton <nickc@redhat.com>,
Xianmiao Qu <cooper.qu@linux.alibaba.com>,
binutils@sourceware.org, lifang_xia@linux.alibaba.com
Subject: Re: [PATCH] C-SKY: Fix machine flag.
Date: Tue, 17 Jan 2023 13:53:05 +0100 [thread overview]
Message-ID: <f983284e9a36470d4cc9f263e00a2493355ddbe3.camel@klomp.org> (raw)
In-Reply-To: <b453e36f-7811-34a9-0316-4128ca6bf775@redhat.com>
Hi,
On Tue, 2023-01-17 at 11:49 +0000, Nick Clifton via Binutils wrote:
> Hi Xianmiao Qu,
>
> > bfd/
> > * elf32-csky.c (elf32_csky_merge_attributes): Don't save
> > and restore the ARCH attribute, it will actually clear
> > the ARCH attribute.
> > (csky_elf_merge_private_bfd_data): Store the machine flag
> > correctly.
>
> Approved and applied.
Note that this broke the build on all arches:
https://builder.sourceware.org/buildbot/#/changes/17260
../../binutils-gdb/bfd/elf32-csky.c: In function
‘elf32_csky_merge_attributes’:
../../binutils-gdb/bfd/elf32-csky.c:2867:17: error: unused variable
‘tattr’ [-Werror=unused-variable]
2867 | obj_attribute tattr;
| ^~~~~
../../binutils-gdb/bfd/elf32-csky.c: In function
‘csky_elf_merge_private_bfd_data’:
../../binutils-gdb/bfd/elf32-csky.c:3067:56: error: suggest parentheses
around comparison in operand of ‘&’ [-Werror=parentheses]
3067 | || (new_flags & (CSKY_ARCH_MASK | CSKY_ABI_MASK) !=
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
3068 | old_flags & (CSKY_ARCH_MASK | CSKY_ABI_MASK)))
| ~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:1765: elf32-csky.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
next prev parent reply other threads:[~2023-01-17 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 12:54 Xianmiao Qu
2023-01-17 11:49 ` Nick Clifton
2023-01-17 12:53 ` Mark Wielaard [this message]
2023-01-17 12:57 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f983284e9a36470d4cc9f263e00a2493355ddbe3.camel@klomp.org \
--to=mark@klomp.org \
--cc=binutils@sourceware.org \
--cc=cooper.qu@linux.alibaba.com \
--cc=lifang_xia@linux.alibaba.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).