* [PATCH] GAS/MIPS: add "--defsym r6=" for default when it's r6
@ 2023-11-14 6:22 YunQiang Su
2023-11-15 13:45 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: YunQiang Su @ 2023-11-14 6:22 UTC (permalink / raw)
To: nickc; +Cc: binutils, YunQiang Su
In mips.exp, `mips_arch_create` is used to create an test arch,
and it will try to create a `default` arch.
When our gas is configured as mips32r6/mips64r6, the '--defsym r6='
option is missing when create `default`.
Let's add it back.
---
gas/testsuite/gas/mips/mips.exp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index 86753e57b79..0611273cac6 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -161,6 +161,12 @@ proc mips_arch_create {arch gprsize extends props as_flags objdump_flags
set archdata(displayname) "default = $arch"
set archdata(as_flags) ""
+ if { [string compare $arch mips32r6] == 0
+ || [string compare $arch mips64r6] == 0} {
+ set archdata(as_flags) "--defsym r6="
+ } else {
+ set archdata(as_flags) ""
+ }
set archdata(objdump_flags) ""
set mips_arches(default) [array get archdata]
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] GAS/MIPS: add "--defsym r6=" for default when it's r6
2023-11-14 6:22 [PATCH] GAS/MIPS: add "--defsym r6=" for default when it's r6 YunQiang Su
@ 2023-11-15 13:45 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2023-11-15 13:45 UTC (permalink / raw)
To: YunQiang Su; +Cc: binutils
Hi YunQiang Su,
> In mips.exp, `mips_arch_create` is used to create an test arch,
> and it will try to create a `default` arch.
> When our gas is configured as mips32r6/mips64r6, the '--defsym r6='
> option is missing when create `default`.
Patch approved and applied.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-15 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-14 6:22 [PATCH] GAS/MIPS: add "--defsym r6=" for default when it's r6 YunQiang Su
2023-11-15 13:45 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).