public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <binutils@emagii.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH v4 0/6] ASCIZ Command for output section
Date: Tue, 14 Feb 2023 17:07:20 +0100	[thread overview]
Message-ID: <fcba73a3-cb38-7290-cffb-2e51e6766c04@emagii.com> (raw)
In-Reply-To: <235dfe58-9c1e-8b2d-9f9b-1a3d12e4ab52@redhat.com>

Thank You.

I will start to try to implement the "ASCII" command as well.

ASCII <length> , <string>

I had some problems with getting syntax errors on this so I think
I will send in a preliminary patchset and see if anyone can spot an 
obvious error.


One question:
    The lang_add_string contains an error message if the string does not 
fit into the allocated area.
    This will never get triggered by the ASCIZ command, since that will 
allocate the size of the string.
    If you specify a size to the ASCII command and then provide a longer 
string it will trigger.

    There are no translations for the string at the moment.

    Will the linker output the English string, or what?

    What is the procedure to get a translation?
    I can provide a Swedish translation at the least.

Best Regards
Ulf Samuelsson

Den 2023-02-14 kl. 11:16, skrev Nick Clifton:
> Hi Ulf,
>
>> Introduce an ASCIZ command for an output section
>> When generating a header for an embedded system
>> there is often a need to add text information.
>
> Thanks for contributing this patch series.  I have applied
> the patches with a few minor tweaks - mostly to the new
> test case so that it did not cause new failures on targets
> which pad code to an alignment greater than 4 bytes.
>
> Cheers
>   Nick
>
>

  reply	other threads:[~2023-02-14 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 16:20 binutils
2023-02-13 16:20 ` [PATCH v4 1/6] Document the ASCIZ command binutils
2023-02-13 16:20 ` [PATCH v4 2/6] Add ASCIZ to NEWS binutils
2023-02-13 16:20 ` [PATCH v4 3/6] Add ASCIZ to testsuite binutils
2023-02-13 16:20 ` [PATCH v4 4/6] ldlex.l: Add ASCIZ token binutils
2023-02-13 16:20 ` [PATCH v4 5/6] ldgram.y: Add 'ASCIZ <string>' command binutils
2023-02-13 16:24 ` [PATCH v4 0/6] ASCIZ Command for output section Ulf Samuelsson
2023-02-14 10:16 ` Nick Clifton
2023-02-14 16:07   ` Ulf Samuelsson [this message]
2023-02-14 16:20     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcba73a3-cb38-7290-cffb-2e51e6766c04@emagii.com \
    --to=binutils@emagii.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).