From: Nick Clifton <nickc@redhat.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: Commit: Better caching in elf_find_function
Date: Fri, 24 Feb 2023 12:25:29 +0000 [thread overview]
Message-ID: <fed77136-3091-0bbd-d4c1-5be375014932@redhat.com> (raw)
In-Reply-To: <Y/h0/9YO96oOvVOB@squeak.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Hi Alan,
> Failures are seen on mips targets.
>
> mipsel-linux-gnu +FAIL: MIPS PIC relocation 6 (MIPS16)
*sigh* I had noticed these, but thought that they were due to an unrelated problem. :-(
> The first failure is due to this symbol
> 4: 00000000 0 NOTYPE LOCAL DEFAULT [MIPS16] 1 $LCL
> being chosen rather than
> 11: 00000000 32 FUNC GLOBAL DEFAULT [MIPS16] 1 foo
> for an error on the first address of foo. Even if the address fit is
> better, I think a NOTYPE LOCAL ought to not be chosen over a
> FUNC GLOBAL.
Agreed.
I am checking in the attached patch to address this problem. It prefers
function symbols over non-function symbols and typed symbols over notype
symbols. I was not sure if we should prefer LOCAL symbols over GLOBALS
so I did not add code for that.
Cheers
Nick
[-- Attachment #2: elf-find-function.patch.2 --]
[-- Type: application/x-troff-man, Size: 3046 bytes --]
prev parent reply other threads:[~2023-02-24 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 17:26 Nick Clifton
2023-02-24 8:27 ` Alan Modra
2023-02-24 12:25 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed77136-3091-0bbd-d4c1-5be375014932@redhat.com \
--to=nickc@redhat.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).