PATCH: Use generic_print_address for address

PATCH: Use generic_print_address for address

[H. J. Lu]

Diassembler should use generic_print_address to print out address.
Otherwise, it doesn't work with 64bit address.


H.J.
----
2005-02-11  H.J. Lu  <hongjiu.lu@intel.com>

	* dis-buf.c (perror_memory): Use generic_print_address to
	print out address.

--- opcodes/dis-buf.c.vma	2003-11-17 12:30:30.000000000 -0800
+++ opcodes/dis-buf.c	2005-02-11 15:28:58.787914148 -0800
@@ -56,10 +56,13 @@ perror_memory (status, memaddr, info)
     /* Can't happen.  */
     info->fprintf_func (info->stream, _("Unknown error %d\n"), status);
   else
-    /* Actually, address between memaddr and memaddr + len was
-       out of bounds.  */
-    info->fprintf_func (info->stream,
-			_("Address 0x%x is out of bounds.\n"), memaddr);
+    {
+      /* Actually, address between memaddr and memaddr + len was
+	 out of bounds.  */
+      info->fprintf_func (info->stream, _("Address 0x"));
+      generic_print_address (memaddr, info);
+      info->fprintf_func (info->stream, _(" is out of bounds.\n"));
+    }
 }
 
 /* This could be in a separate file, to save miniscule amounts of space

Re: PATCH: Use generic_print_address for address

[Andreas Schwab]

"H. J. Lu" <hjl@lucon.org> writes:

> +      info->fprintf_func (info->stream, _("Address 0x"));
> +      generic_print_address (memaddr, info);
> +      info->fprintf_func (info->stream, _(" is out of bounds.\n"));

This is very i18n unfriendly.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: PATCH: Use generic_print_address for address

[H. J. Lu]

On Sat, Feb 12, 2005 at 12:55:16AM +0100, Andreas Schwab wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> 
> > On Sat, Feb 12, 2005 at 12:39:12AM +0100, Andreas Schwab wrote:
> >> "H. J. Lu" <hjl@lucon.org> writes:
> >> 
> >> > +      info->fprintf_func (info->stream, _("Address 0x"));
> >> > +      generic_print_address (memaddr, info);
> >> > +      info->fprintf_func (info->stream, _(" is out of bounds.\n"));
> >> 
> >> This is very i18n unfriendly.
> >> 
> >
> > Do you have any suggestions?
> 
> If there is a way to format the address into a buffer then the format
> string can be combined again.
> 

Like this?


H.J.
----
2005-02-11  H.J. Lu  <hongjiu.lu@intel.com>

	* dis-buf.c (perror_memory): Use sprintf_vma to print out
	address.

--- opcodes/dis-buf.c.vma	2003-11-17 12:30:30.000000000 -0800
+++ opcodes/dis-buf.c	2005-02-11 16:20:38.508542555 -0800
@@ -56,10 +56,15 @@ perror_memory (status, memaddr, info)
     /* Can't happen.  */
     info->fprintf_func (info->stream, _("Unknown error %d\n"), status);
   else
-    /* Actually, address between memaddr and memaddr + len was
-       out of bounds.  */
-    info->fprintf_func (info->stream,
-			_("Address 0x%x is out of bounds.\n"), memaddr);
+    {
+      char buf[30];
+
+      /* Actually, address between memaddr and memaddr + len was
+	 out of bounds.  */
+      sprintf_vma (buf, memaddr);
+      info->fprintf_func (info->stream,
+			  _("Address 0x%s is out of bounds.\n"), buf);
+    }
 }
 
 /* This could be in a separate file, to save miniscule amounts of space

Re: PATCH: Use generic_print_address for address

[Nick Clifton]

Hi H. J.

> 2005-02-11  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* dis-buf.c (perror_memory): Use sprintf_vma to print out
> 	address.

Approved - please apply.

Cheers
   Nick