From: Nick Clifton <nickc@redhat.com>
To: binutils@sources.redhat.com
Subject: Fix for compile time warning in binutils/nlmconv.c
Date: Tue, 15 Feb 2005 18:17:00 -0000 [thread overview]
Message-ID: <m3oeelansx.fsf@redhat.com> (raw)
Hi Guys,
I am going to apply the patch below to fix a compile time warning
when building nlmconv.c, although I am not sure if this is the
proper way to fix the problem. The reason is that I am not sure why
the parameterless prototype for localtime() is included at all.
Presumably there are build environments out there where this
function is not prototyped, or the header containing the prototype
is not pulled in. To me this sounds like a configure problem, but
for now I am keeping things simple.
Cheers
Nick
binutils/ChangeLog
2005-02-15 Nick Clifton <nickc@redhat.com>
* nlmconv.c: Provide a full prototype for the localtime() function
in order to avoid a compile time warning.
Index: binutils/nlmconv.c
===================================================================
RCS file: /cvs/src/src/binutils/nlmconv.c,v
retrieving revision 1.21
diff -c -3 -p -r1.21 nlmconv.c
*** binutils/nlmconv.c 4 Jan 2005 15:51:47 -0000 1.21
--- binutils/nlmconv.c 15 Feb 2005 14:20:18 -0000
***************
*** 59,65 ****
extern char *strerror (int);
#ifndef localtime
! extern struct tm *localtime ();
#endif
#ifndef SEEK_SET
--- 59,65 ----
extern char *strerror (int);
#ifndef localtime
! extern struct tm *localtime (const time_t *);
#endif
#ifndef SEEK_SET
next reply other threads:[~2005-02-15 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 18:17 Nick Clifton [this message]
2005-02-15 18:33 ` Ian Lance Taylor
2005-02-16 19:22 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oeelansx.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).