public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: pjones@redhat.com
Cc: binutils@sourceware.org, schwab@suse.de, pjones@redhat.com
Subject: Re: [PATCH] Handle "efi-app-riscv64" and similar targets in objcopy.
Date: Mon, 04 Dec 2023 09:16:13 -0800 (PST)	[thread overview]
Message-ID: <mhng-9d68ca7d-ffbd-4db8-8663-847de4114104@palmer-ri-x1c9> (raw)
In-Reply-To: <20230906200134.1033297-2-pjones@redhat.com>

On Wed, 06 Sep 2023 13:01:34 PDT (-0700), pjones@redhat.com wrote:
> This adds the efi target name handling for riscv64 to objcopy.
>
> binutils:
> 	* binutils/objcopy.c: add riscv64 handling to
> 	  convert_efi_target()
>
> Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
>  binutils/objcopy.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> index 2ce1b07bf7c..b64cbee3dd7 100644
> --- a/binutils/objcopy.c
> +++ b/binutils/objcopy.c
> @@ -5129,6 +5129,11 @@ convert_efi_target (char **targ)
>        /* Change aarch64 to aarch64-little.  */
>        memcpy (pei + 4 + sizeof ("aarch64") - 1, "-little", sizeof ("-little"));
>      }
> +  else if (strcmp (efi + 4, "riscv64") == 0)
> +    {
> +      /* Change riscv64 to riscv64-little.  */
> +      memcpy (pei + 4 + sizeof ("riscv64") - 1, "-little", sizeof ("-little"));
> +    }
>    *targ = pei;
>    return subsys;
>  }

Sorry I missed this, David just poked me.

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!

  reply	other threads:[~2023-12-04 17:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 14:18 [PATCH] Add basic support for RISC-V 64-bit EFI objects Andreas Schwab
2023-08-09  1:54 ` Palmer Dabbelt
2023-08-09  8:10   ` Andreas Schwab
2023-08-25  2:15     ` Nelson Chu
2023-08-25 13:26       ` Palmer Dabbelt
2023-08-28  2:03         ` Nelson Chu
2023-09-06 15:40           ` Palmer Dabbelt
2023-09-06 20:01 ` Peter Jones
2023-09-06 20:01   ` [PATCH] Handle "efi-app-riscv64" and similar targets in objcopy Peter Jones
2023-12-04 17:16     ` Palmer Dabbelt [this message]
2023-12-05  6:45       ` Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-9d68ca7d-ffbd-4db8-8663-847de4114104@palmer-ri-x1c9 \
    --to=palmer@dabbelt.com \
    --cc=binutils@sourceware.org \
    --cc=pjones@redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).