public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: buildbot@sourceware.org
Cc: Sam James <sam@gentoo.org>
Subject: [PATCH v2] autoregen.py: handle aclocal
Date: Wed, 15 Nov 2023 15:17:04 +0000	[thread overview]
Message-ID: <20231115151721.2554589-1-sam@gentoo.org> (raw)

We need to run aclocal which came up earlier with the binutils intl/ drop
(syncing with gcc).

The autotools docs recommend not running it manually but the setup we have
is unconventional.
---
Check for where we are and force an include path if needed. Also, pass --force.

 builder/containers/autoregen.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/builder/containers/autoregen.py b/builder/containers/autoregen.py
index 9315334..3da6d67 100755
--- a/builder/containers/autoregen.py
+++ b/builder/containers/autoregen.py
@@ -26,6 +26,12 @@ for folder in sorted(config_folders):
         continue;
     os.chdir(folder)
     configure_lines = open('configure.ac').read().splitlines()
+    if any(True for line in configure_lines if line.startswith('AC_CONFIG_MACRO_DIRS')):
+        # aclocal does not support the -f short option for force
+        include_arg = ''
+        if (folder / '..' / 'config').is_dir():
+            include_arg = '-I../config'
+        subprocess.check_output(f'{ENV} {ACLOCAL_BIN} --force {include_arg}', shell=True, encoding='utf8')
     if any(True for line in configure_lines if line.startswith('AC_CONFIG_HEADERS')):
         subprocess.check_output(f'{ENV} {AUTOHEADER_BIN} -f', shell=True, encoding='utf8')
     # apparently automake is somehow unstable -> skip it for gotools
-- 
2.42.1


             reply	other threads:[~2023-11-15 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 15:17 Sam James [this message]
2023-11-15 16:53 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115151721.2554589-1-sam@gentoo.org \
    --to=sam@gentoo.org \
    --cc=buildbot@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).