public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: "Serhei Makarov" <serhei@serhei.io>
To: buildbot@sourceware.org
Subject: Re: [PATCH] stap: exclude testsuite/.systemtap-root from bunsen upload
Date: Wed, 24 Apr 2024 10:08:06 -0400	[thread overview]
Message-ID: <6268a387-4869-42c9-8268-b4c61c7f5405@app.fastmail.com> (raw)
In-Reply-To: <e6b76597-6a2c-4039-8165-86a51da7c2b4@app.fastmail.com>

> The testsuite leaves a heap of .log files under
> testsuite/.systemtap-root/cache, which are then picked up by bunsen.
> They shouldn't be.
> ---
>  builder/master.cfg | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builder/master.cfg b/builder/master.cfg
> index 22102b5..1b65e22 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -4745,7 +4745,8 @@ systemtap_privileged_factory.addStep(steps.Test(
>          haltOnFailure=False, flunkOnFailure=False)) # some failures 
> are normal for stap
>  systemtap_privileged_factory.addStep(steps.ShellCommand(
>          workdir="stap-build",
> -        command=["rm", "-rf", "testsuite/.systemtap-buildbot/cache"], 
> # ugly hardcoding bot username :-(
> +        command=["rm", "-rf", "testsuite/.systemtap-buildbot/cache", # 
> ugly hardcoding bot username :-(
> +                 "testsuite/.systemtap-root"], # contains .log files, 
> should be excluded from bunsen upload
>          name="cleanup caches",
>          haltOnFailure=True))
>  systemtap_privileged_factory.addSteps(bunsen_logfile_upload_cpio_steps(
> --
> 2.43.0

(Used my own privileges to commit this after checking with Frank.)

      reply	other threads:[~2024-04-24 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 14:00 Serhei Makarov
2024-04-24 14:08 ` Serhei Makarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6268a387-4869-42c9-8268-b4c61c7f5405@app.fastmail.com \
    --to=serhei@serhei.io \
    --cc=buildbot@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).