From: "Jose E. Marchesi" <jemarch@gnu.org>
To: Mark Wielaard <mark@klomp.org>
Cc: "Arsen Arsenović" <arsen@aarsen.me>,
buildbot@sourceware.org, poke-devel@gnu.org
Subject: Re: [PATCH builder.git] master.cfg: add GNU poke builder
Date: Wed, 23 Nov 2022 12:53:55 +0100 [thread overview]
Message-ID: <87ilj5zy24.fsf@gnu.org> (raw)
In-Reply-To: <Y31rOQoucGJJvbIf@wildebeest.org> (Mark Wielaard's message of "Wed, 23 Nov 2022 01:37:13 +0100")
> BTW. I tried on debian-i386, but got some test failures/crashes:
>
> The following patch seems to fix that:
>
> diff --git a/libpoke/pkl-lex.l b/libpoke/pkl-lex.l
> index 4c9b013e..ef562ccb 100644
> --- a/libpoke/pkl-lex.l
> +++ b/libpoke/pkl-lex.l
> @@ -176,7 +176,7 @@ build_overflow_error_msg (uint64_t value, int width)
> : "");
>
> asprintf (&msg,
> - "signed overflow\ntry: %luU%s as int<%d>",
> + "signed overflow\ntry: %" PRIu64 "U%s as int<%d>",
> value, suffix, width);
> return msg;
> }
I just applied that fix in master.
We only develop in 64-bit, so we usually only catch these regressions
before doing releases, when I make a point to test in 32-bit.
The autobuild already paid back, in a way ;)
Thanks!
next prev parent reply other threads:[~2022-11-23 11:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 23:36 Arsen Arsenović
2022-11-20 11:48 ` Jose E. Marchesi
2022-11-20 12:21 ` Arsen Arsenović
2022-11-20 13:17 ` Frank Ch. Eigler
2022-11-20 14:43 ` Arsen Arsenović
2022-11-20 15:31 ` Frank Ch. Eigler
2022-11-20 16:05 ` Arsen Arsenović
2022-11-20 14:12 ` Jose E. Marchesi
2022-11-23 0:37 ` Mark Wielaard
2022-11-23 11:53 ` Jose E. Marchesi [this message]
2022-11-23 17:44 ` Mark Wielaard
2022-11-23 20:20 ` Mohammad-Reza Nabipoor
2022-11-24 12:11 ` Mark Wielaard
2022-11-28 16:48 ` Frank Ch. Eigler
2022-11-28 19:09 ` Arsen Arsenović
2022-11-28 21:53 ` Frank Ch. Eigler
2022-11-29 11:55 ` Mohammad-Reza Nabipoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilj5zy24.fsf@gnu.org \
--to=jemarch@gnu.org \
--cc=arsen@aarsen.me \
--cc=buildbot@sourceware.org \
--cc=mark@klomp.org \
--cc=poke-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).