libsframe builder (Was: [PATCH 0/2] libsframe: fix some memory leaks)

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi Indu,

On Thu, 2022-12-22 at 14:54 -0800, Indu Bhagat via Binutils wrote:
> This patch set fixes some memory leaks in the libsframe and it's
> testsuite.

I see you are an enthusiastic user of the binutils-try buildbot. But
changes under libsframe/ don't trigger new builds and the libsframe
testsuite isn't actually ran.

The following tweak to the buildbot master.cfg should fix that.

Please let buildbot@sourceware.org know if you need more tweaks to
better test the new code.

Cheers,

Mark

[-- Attachment #2: 0001-Add-libsframe-to-binutils_files.patch --]
[-- Type: text/x-patch, Size: 3031 bytes --]

From b58f0c5e82062f9c1160b72bba62a425c993fc79 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 23 Dec 2022 14:44:53 +0100
Subject: [PATCH] Add libsframe to binutils_files

Because gdb and binutils share a git repo we only trigger builds
if they are part of gdb or binutils. libsframe is a new subdir
part of binutils.

Also add an explicit check-libsframe to binutils_step_checks.
---
 builder/master.cfg | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index 1e17aa3..8a66ae8 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -671,6 +671,7 @@ c['schedulers'].append(gccrust_bootstrap_scheduler)
 binutils_files = ["bfd/",
                   "binutils/", "gas/", "ld/",
                   "libctf/",
+                  "libsframe/",
                   "gold/", "elfcpp/",
                   "include/", "libiberty/", "opcodes/",
                   "configure", "Makefile.in"]
@@ -2106,14 +2107,17 @@ binutils_step_check = steps.Test(
         workdir='binutils-build',
         command=['make',
                  util.Interpolate('-j%(prop:ncpus)s'),
-                 'check-ld', 'check-gas', 'check-binutils'],
+                 'check-ld', 'check-gas', 'check-binutils',
+                 'check-libsframe'],
         name='make check',
         logfiles={ "ld.sum": "ld/ld.sum",
                    "ld.log": "ld/ld.log",
                    "gas.sum": "gas/testsuite/gas.sum",
                    "gas.log": "gas/testsuite/gas.log",
                    "binutils.sum": "binutils/binutils.sum",
-                   "binutils.log": "binutils/binutils.log" },
+                   "binutils.log": "binutils/binutils.log",
+                   "libsframe.sum": "libsframe/libsframe.sum",
+                   "libsframe.log": "libsframe/libsframe.log" },
         haltOnFailure=False, flunkOnFailure=True)
 binutils_steps_bunsen = bunsen_logfile_upload_cpio_steps(
         ["*.sum", "*.log"],
@@ -2123,7 +2127,8 @@ binutils_step_check_libctf = steps.Test(
         workdir='binutils-build',
         command=['make',
                  util.Interpolate('-j%(prop:ncpus)s'),
-                 'check-ld', 'check-gas', 'check-binutils', 'check-libctf'],
+                 'check-ld', 'check-gas', 'check-binutils', 'check-libctf',
+                 'check-libsframe'],
         name='make check',
         logfiles={ "ld.sum": "ld/ld.sum",
                    "ld.log": "ld/ld.log",
@@ -2131,6 +2136,8 @@ binutils_step_check_libctf = steps.Test(
                    "gas.log": "gas/testsuite/gas.log",
                    "binutils.sum": "binutils/binutils.sum",
                    "binutils.log": "binutils/binutils.log",
+                   "libsframe.sum": "libsframe/libsframe.sum",
+                   "libsframe.log": "libsframe/libsframe.log",
                    "libctf.sum": "libctf/libctf.sum",
                    "libctf.log": "libctf/libctf.log" },
         haltOnFailure=False, flunkOnFailure=True)
-- 
2.18.4