public inbox for
 help / color / mirror / Atom feed
From: Mark Wielaard <>
Subject: Re: [PATCH] Upgrade to buildbot 3.6.1
Date: Sun, 9 Oct 2022 14:53:36 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Sun, Oct 09, 2022 at 01:12:56AM +0200, Mark Wielaard wrote:
> This includes our patch for:
> - Fixed issue with DockerLatentWorker accumulating connections with
>   the docker server (issue #6538).
> It will hopefully also fix our git upgrade failure issue:
> - Fixed “retry fetch” and “clobber on failure” git checkout options.
> Include upgrade instructions in README.

The upgrade seems to work well, but I did have to revert one upstream
commit to get email reporters to work again:

commit ab24f39532067b8fbe0f980caab19956c2be54f0
Author: Oleksii Odynochenko <>
Date:   Wed Jul 27 12:17:00 2022 +0300

    reporters: fix email sending with Twisted 21.2.0+
    Seems that hostname argument to ESMTPSenderFactory is mandatory.

diff --git a/master/buildbot/reporters/ b/master/buildbot/reporters/
index 4fa020808..bc2979d22 100644
--- a/master/buildbot/reporters/
+++ b/master/buildbot/reporters/
@@ -336,7 +336,7 @@ class MailNotifier(ReporterBase):
             unicode2bytes(self.smtpUser), unicode2bytes(self.smtpPassword),
             parseaddr(self.fromaddr)[1], recipients, BytesIO(s),
             result, requireTransportSecurity=self.useTls,
-            requireAuthentication=useAuth)
+            requireAuthentication=useAuth, hostname=self.relayhost)
         if self.useSmtps:
             reactor.connectSSL(self.relayhost, self.smtpPort,

This seems to be this upstream issue:



      reply	other threads:[~2022-10-09 12:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08 23:12 Mark Wielaard
2022-10-09 12:53 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).