public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Luis Machado <luis.machado@arm.com>
Cc: buildbot@sourceware.org
Subject: Re: Fedora arm64 packages for gdb testing
Date: Mon, 18 Jul 2022 23:49:05 +0200	[thread overview]
Message-ID: <YtXVUUxTMNeS2D6Z@wildebeest.org> (raw)
In-Reply-To: <fa603c35-f130-75d9-f342-9e171dc045c3@arm.com>

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hi Luis,

On Mon, Jul 18, 2022 at 09:20:23AM +0100, Luis Machado wrote:
> > I noticed libexpat-devel isn't installed on other builders. Is it only
> > necessary on arm? Or should we make sure it is always installed?
>
> It may be the case that other targets don't rely as much on XML
> descriptions as the Arm port does.
>
> I'd recommend always installing libexpat on the builders to get the
> best outcome.

OK I checked and/or installed for:

fedora-s390x expat-devel-2.4.7-1.fc36.s390x
fedora-ppc64le expat-devel-2.4.7-1.fc36.ppc64le
centos-x86_64 expat-devel-2.1.0-14.el7_9.x86_64
debian-i386 libexpat1-dev-2.2.10-2+deb11u3
debian-armhf libexpat1-dev-2.2.6-2+deb10u4
debian-arm64 libexpat1-dev-2.2.6-2+deb10u4

And the fedora and debian containers now got it added.
opensuse containers already had libexpat-devel installed.
(note how each distro calls the package by a slightly differnt name, sigh)

Cheers,

Mark

[-- Attachment #2: 0001-Add-libexpat-dev-expat-devel-to-fedora-and-debian-co.patch --]
[-- Type: text/x-diff, Size: 3363 bytes --]

From 97e90a71c93e7810b517fb9ed5006a3d958840bf Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Mon, 18 Jul 2022 23:43:17 +0200
Subject: [PATCH] Add libexpat-dev/expat-devel to fedora and debian containers

opensuse containers already had libexpat-devel installed
---
 builder/containers/Containerfile-debian-stable  | 1 +
 builder/containers/Containerfile-debian-testing | 1 +
 builder/containers/Containerfile-fedora-latest  | 1 +
 builder/containers/Containerfile-fedora-rawhide | 1 +
 4 files changed, 4 insertions(+)

diff --git a/builder/containers/Containerfile-debian-stable b/builder/containers/Containerfile-debian-stable
index c1ca117..d7c1973 100644
--- a/builder/containers/Containerfile-debian-stable
+++ b/builder/containers/Containerfile-debian-stable
@@ -9,6 +9,7 @@ RUN apt-get update && \
       coreutils make git autotools-dev autoconf dejagnu automake gettext bison flex \
       gawk m4 pkg-config gettext autopoint \
       bzip2 libbz2-dev xz-utils liblzma-dev gzip zlib1g-dev zstd libzstd-dev \
+      libexpat-dev \
       findutils file tar curl libarchive-tools libarchive-dev libcurl4-gnutls-dev \
       libmicrohttpd-dev libsqlite3-dev libelf-dev libdw-dev elfutils \
       libdebuginfod-dev \
diff --git a/builder/containers/Containerfile-debian-testing b/builder/containers/Containerfile-debian-testing
index b72b7fe..57c1e63 100644
--- a/builder/containers/Containerfile-debian-testing
+++ b/builder/containers/Containerfile-debian-testing
@@ -9,6 +9,7 @@ RUN apt-get update && \
       coreutils make git autotools-dev autoconf dejagnu automake gettext bison flex \
       gawk m4 pkg-config gettext autopoint \
       bzip2 libbz2-dev xz-utils liblzma-dev gzip zlib1g-dev zstd libzstd-dev \
+      libexpat-dev \
       findutils file tar curl libarchive-tools libarchive-dev libcurl4-gnutls-dev \
       libmicrohttpd-dev libsqlite3-dev libelf-dev libdw-dev elfutils \
       libdebuginfod-dev \
diff --git a/builder/containers/Containerfile-fedora-latest b/builder/containers/Containerfile-fedora-latest
index e8e4ad4..d662195 100644
--- a/builder/containers/Containerfile-fedora-latest
+++ b/builder/containers/Containerfile-fedora-latest
@@ -7,6 +7,7 @@ RUN dnf upgrade -y && \
         patch util-linux diffutils iproute bsdtar cpio procps \
         coreutils make git autoconf dejagnu automake gettext-devel bison flex \
         bzip2 bzip2-devel xz xz-devel gzip zlib-devel zstd libzstd-devel \
+        expat-devel \
         findutils file tar curl libarchive-devel libcurl-devel \
         libmicrohttpd-devel sqlite-devel elfutils elfutils-devel ncurses-devel \
         texinfo \
diff --git a/builder/containers/Containerfile-fedora-rawhide b/builder/containers/Containerfile-fedora-rawhide
index 1405276..543828a 100644
--- a/builder/containers/Containerfile-fedora-rawhide
+++ b/builder/containers/Containerfile-fedora-rawhide
@@ -7,6 +7,7 @@ RUN dnf upgrade -y && \
         patch util-linux diffutils iproute bsdtar cpio procps \
         coreutils make git autoconf dejagnu automake gettext-devel bison flex \
         bzip2 bzip2-devel xz xz-devel gzip zlib-devel zstd libzstd-devel \
+        expat-devel \
         findutils file tar curl libarchive-devel libcurl-devel \
         libmicrohttpd-devel sqlite-devel elfutils elfutils-devel ncurses-devel \
         texinfo \
-- 
2.30.2


  reply	other threads:[~2022-07-18 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15 12:05 Luis Machado
2022-07-17 16:39 ` Mark Wielaard
2022-07-18  8:20   ` Luis Machado
2022-07-18 21:49     ` Mark Wielaard [this message]
2022-07-18 22:14       ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtXVUUxTMNeS2D6Z@wildebeest.org \
    --to=mark@klomp.org \
    --cc=buildbot@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).