From: "Frank Ch. Eigler" <fche@elastic.org>
To: Mark Wielaard <mark@klomp.org>
Cc: buildbot@sourceware.org
Subject: Re: [PATCH] Add binutils-gdb-autoregen builder
Date: Sun, 12 Nov 2023 11:49:11 -0500 [thread overview]
Message-ID: <ZVECB_5PCtf2FW4R@elastic.org> (raw)
In-Reply-To: <20231112161906.1539555-1-mark@klomp.org>
Hi -
> Generalize the autoregen.py script by searching for 'configure.ac'
> instead of 'configure'. Skip "foreign" readline and minizip dirs.
> Make autoregen_step and git_diff_step generic, define early.
> Add binutils-gdb-autoregen builder to binutils_gdb_scheduler.
> +autoregen_step = steps.ShellCommand(
> + command="autoregen.py",
> + name="autoregen.py",
> + haltOnFailure=True)
Note that this stuff literally can only add work for the developers.
If the tooling knows what the output purportedly should be, it is in a
position to correct the mismatches, not merely complain about it.
That would actually save human effort.
- FChE
next prev parent reply other threads:[~2023-11-12 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 16:19 Mark Wielaard
2023-11-12 16:49 ` Frank Ch. Eigler [this message]
2023-11-12 17:19 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVECB_5PCtf2FW4R@elastic.org \
--to=fche@elastic.org \
--cc=buildbot@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).