[PATCH] Use binary mode to read .log/.sum

[PATCH] Use binary mode to read .log/.sum

[Keith Seitz]

There's no guarantee that gdb.{log,sum} will not contain non-UTF-8
encoded characters.  This can happen, for example, when either gdb or
the inferior outputs uninitialized data (either intentionally or as a
result of some bug). gdb.fortran/function-calls.exp is a common
problem.

Since Cursor will decode lines using UTF-8, nothing is really sacrificed.
However, this does fix several import problems I've encountered where
stray/garbage bytes have caused the import to abort prematurely.
---
 scripts-master/gdb/parse_dejagnu.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/scripts-master/gdb/parse_dejagnu.py b/scripts-master/gdb/parse_dejagnu.py
index 5218e9a..c9f30ac 100755
--- a/scripts-master/gdb/parse_dejagnu.py
+++ b/scripts-master/gdb/parse_dejagnu.py
@@ -65,11 +65,14 @@ def get_outcome_line(testcase):
 datestamp_format = '%a %b %d %H:%M:%S %Y'
 
 def openfile_or_xz(path):
+    # Read in bary mode to suppress encoding problems that might occur
+    # from reading gdb.{log,sum}. Sometimes inferiors or gdb can just output
+    # garbage bytes.
     if os.path.isfile(path):
-        return open(path, mode='rt')
+        return open(path, mode='rb')
     elif os.path.isfile(path+'.xz'):
-        return lzma.open(path+'.xz', mode='rt')
-    return open(path, mode='rt') # XXX trigger default error
+        return lzma.open(path+'.xz', mode='rb')
+    return open(path, mode='rb') # XXX trigger default error
 
 def parse_README(testrun, READMEfile):
     if testrun is None: return None
-- 
2.26.2