public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
From: "Serhei Makarov" <me@serhei.io>
To: "Keith Seitz" <keiths@redhat.com>, Bunsen <bunsen@sourceware.org>
Subject: Re: [PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs
Date: Thu, 05 Aug 2021 15:28:46 -0400	[thread overview]
Message-ID: <b7df61b8-d3f8-40ca-9f0e-10043f27f5a7@www.fastmail.com> (raw)
In-Reply-To: <20210805184211.10976-1-keiths@redhat.com>

On Thu, Aug 5, 2021, at 2:42 PM, Keith Seitz via Bunsen wrote:
> `grok_architecture' is called from gdb's commit_logs function.
> However at this moment, we actually can't do anything to ascertain
> the architecture. This function is currently passing the `testdir'
> variable, which is non-sensical.
> 
> Architecture is actually grok'd in annotate_dejagnu_log, so simply
> remove the call here.
The history of this line is that I was importing results from Sergio's buildbots,
where they were organized in directory and the name of the directory was the most obvious
(iirc the only) source for some of the arch/distro information.

Looks like this is the result of a messed up refactoring. At some point grok_architecture was
local to commit_logs and did a more flexible match for architecture names.

Therefore, ok to commit the patch. (I'll do it myself later on if you're busy, but it might be
good to test that you have commit access.)

All the best,
      Serhei

  reply	other threads:[~2021-08-05 19:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 18:42 Keith Seitz
2021-08-05 19:28 ` Serhei Makarov [this message]
2021-08-05 19:48   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7df61b8-d3f8-40ca-9f0e-10043f27f5a7@www.fastmail.com \
    --to=me@serhei.io \
    --cc=bunsen@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).