From: Keith Seitz <keiths@redhat.com>
To: Serhei Makarov <me@serhei.io>
Cc: Bunsen <bunsen@sourceware.org>
Subject: Re: Initial findings of bunsen performance and questions
Date: Mon, 21 Sep 2020 13:16:42 -0700 [thread overview]
Message-ID: <f902d8fa-f5df-1093-f6f0-b630f1f55af2@redhat.com> (raw)
In-Reply-To: <8e645045-04e6-412d-97d2-46a173d2fefa@www.fastmail.com>
On 9/21/20 1:08 PM, Serhei Makarov wrote:
> For the record: as I understood, you wanted to store individual testcases
> (consolidate_pass=False) since you wanted to have a Cursor giving the line
> range for every passing testcase in the .log.
Yes, that's correct.
> So fixing the Cursor deserialization performance is really necessary.
>
> Thankfully, it's possible to make the regexp parsing into an on-demand operation
> that occurs when a particular Cursor's line_start/line_end/testlog fields are accessed.
> commit 2ed3d13f76c3 should solve the issue, reducing the observed 58sec parsing time to 2s.
> https://sourceware.org/git/?p=bunsen.git;a=commitdiff;h=2ed3d13f76c37418cfd4180b149bca0e533ec92f
>
Awesome. That fixes things nicely (and sufficiently). I think this will
simplify the API design/implementation for database-based use cases.
Thanks,
Keith
prev parent reply other threads:[~2020-09-21 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 22:18 Keith Seitz
2020-09-16 23:09 ` Serhei Makarov
2020-09-18 16:16 ` Keith Seitz
2020-09-21 20:08 ` Serhei Makarov
2020-09-21 20:16 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f902d8fa-f5df-1093-f6f0-b630f1f55af2@redhat.com \
--to=keiths@redhat.com \
--cc=bunsen@sourceware.org \
--cc=me@serhei.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).